Fix Steam download failures and dead Retry/Resume#623
Merged
Conversation
maxjivi05
commented
Jul 13, 2026
maxjivi05
commented
Contributor
- Handle downloadApp() null returns in startQueued: requeue when AppInfo isn't loaded yet, otherwise mark the record FAILED instead of leaving it wedged in DOWNLOADING (which blocked the slot and made Retry a no-op)
- Let resume() requeue DOWNLOADING records with no live transfer via new Dispatcher.isTransferActive, unwedging already-stuck downloads
- Tick the download queue after Steam logon so requeued records start
- Refresh manifest request codes right before each depot's manifest fetch (Steam rotates them ~every 5 min, so codes pre-resolved at download start expired for later depots of multi-depot games, causing 401 manifest fetch failures)
- Keep resume state on transient download failures so Retry continues from the same offset instead of restarting
- Handle downloadApp() null returns in startQueued: requeue when AppInfo isn't loaded yet, otherwise mark the record FAILED instead of leaving it wedged in DOWNLOADING (which blocked the slot and made Retry a no-op) - Let resume() requeue DOWNLOADING records with no live transfer via new Dispatcher.isTransferActive, unwedging already-stuck downloads - Tick the download queue after Steam logon so requeued records start - Refresh manifest request codes right before each depot's manifest fetch (Steam rotates them ~every 5 min, so codes pre-resolved at download start expired for later depots of multi-depot games, causing 401 manifest fetch failures) - Keep resume state on transient download failures so Retry continues from the same offset instead of restarting
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.