Add sysio::chain::application for common code of wire applications - #178
Merged
Conversation
…ing if in handle_exception. Fix spelling of handle_exception.
heifner
changed the title
wire_application for common code of wire applicationssysio::chain::application for common code of wire applications
jglanz
approved these changes
Jan 26, 2026
| */ | ||
| namespace sysio::chain { | ||
|
|
||
| struct wire_application_config { |
Collaborator
There was a problem hiding this comment.
Change to application_config
| uint16_t default_http_port = 8888; | ||
| }; | ||
|
|
||
| enum return_codes { |
Collaborator
There was a problem hiding this comment.
exit_code?
Also if standard enum, then prefix with RETURN|EXIT_CODE_SUCCESS, etc. If enum class then ignore
| std::scoped_lock lock(mutex); | ||
|
|
||
| for (auto& filename : file_names) { | ||
| FC_ASSERT_FMT(exists(filename), "File does not exist: {}", filename.string()); |
Collaborator
There was a problem hiding this comment.
@jglanz double check in the future but fine for now
|
|
||
| try { | ||
| appbase::scoped_app app; | ||
| chain::application exe{wire_application_config{}}; |
Renamed return_codes to exit_code and wrapped in a namespace.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sysio::chain::applicationgreatly simplifies creation ofnodeoplike applications.