feat(audit): restore css-deep as audit --check css (closes #251)#252
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
cssdeep_engine.py (unused CSS vars, orphan keyframes, specificity wars, duplicate props, unused media queries, z-index abuse) is fully functional — 154 real findings verified on a live workspace — but was orphaned in the #195 consolidation: its command entry point was deleted, the engine kept. Same situation as export-snapshot (#218). CSS is in CodeLens's stated scope (react/css/html), so the loss meant falling back to manual grep for "is this CSS var still used?". Restored as `audit --check css` — a sub-check under the audit umbrella alongside dead-code/complexity/smell/perf-hint (all code-quality analyses), NOT a new top-level command. Command count stays exactly 12 (verified via --command-count) — compatible with the #195 12-umbrella consolidation, not a reversal of it. New scripts/commands/css_deep.py is a thin wrapper (no engine logic duplicated, mirrors export_snapshot.py). --severity and --category passthrough to the engine verified. Design doc at docs/design/0251-restore-css-deep.md.
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #251.
Summary
cssdeep_engine.pywas orphaned in the #195 consolidation (command entry point deleted, engine kept) — 154 real findings but reachable from nowhere. Same as export-snapshot (#218). Restored asaudit --check css(sub-check, not a new top-level command — count stays 12).scripts/commands/css_deep.py— thin wrapper, no engine logic duplicated.--severity/--categorypassthrough verified.docs/design/0251-restore-css-deep.md.Test plan
pytest tests/test_css_deep_command.py— 5/5 (wrapper delegation, passthrough, audit dispatch, severity reaching engine)pytest tests/test_command_registry.py tests/test_issue195_consolidation.py tests/test_command_count.py— pass (css_deep added to impl-module allowlist)--command-count→ 12 (unchanged);sync_command_count.pyclean; design-doc CI check passesaudit . --check css→ 154 findings;--severity high→ 3;--category z_index_abuse→ 1