New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateTimePicker: fix prop warning for #12933

Merged
merged 1 commit into from Jan 23, 2019

Conversation

Projects
None yet
4 participants
@psealock
Copy link
Contributor

psealock commented Dec 16, 2018

Description

Address react propTypes warning for react-dates DayPickerSingleDateController component.

screen shot 2018-12-17 at 12 47 09 pm

It appears the block prop was intended for inputs, which this component does not have, airbnb/react-dates#871.

How has this been tested?

Usage of the <DatePicker /> component does not produce any changes and the warning is removed.

Screenshots

Types of changes

Bug fix: remove unused prop warning.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
@tofumatt
Copy link
Member

tofumatt left a comment

I see some failing tests but I think they might be unrelated to your changes and just a result of wonky test builds from about a month back (sorry for my delay in reviewing this, on that note).

I restarted the tests for now, but if you rebase this branch onto master and force-push it might fix the test failures. Change looks good though.

@youknowriad

This comment has been minimized.

Copy link
Contributor

youknowriad commented Jan 18, 2019

I think this PR might need a rebase to fix the tests?

@psealock psealock force-pushed the psealock:fix/date-time-picker-prop-warning branch from eaf5b19 to efa07ac Jan 20, 2019

@psealock psealock force-pushed the psealock:fix/date-time-picker-prop-warning branch from efa07ac to e564158 Jan 22, 2019

@psealock

This comment has been minimized.

Copy link
Contributor Author

psealock commented Jan 22, 2019

Thanks @youknowriad @tofumatt! Tests passing now.

@youknowriad youknowriad merged commit 5ff463a into WordPress:master Jan 23, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

daniloercoli added a commit that referenced this pull request Jan 24, 2019

Merge branch 'master' of https://github.com/WordPress/gutenberg into …
…rnmobile/372-add-title-to-gutenberg-mobile

* 'master' of https://github.com/WordPress/gutenberg: (56 commits)
  Save package-lock.json file changes (#13481)
  Plugin: Deprecate gutenberg_add_responsive_body_class (#13461)
  Add speak messages to the feature toggle component. (#13385)
  Plugin: Deprecate gutenberg_kses_allowedtags (#13460)
  Plugin: Deprecate gutenberg_bulk_post_updated_messages (#13472)
  Plugin: Avoid calling deprecated gutenberg_silence_rest_errors (#13446)
  Plugin: Deprecate gutenberg_remove_wpcom_markdown_support (#13473)
  Fix: Categories block: add custom classes only to wrapper (#13439)
  is-shallow-equal: Use ES5 ruleset from eslint-plugin module (#13428)
  Update and Organize Contributors Guide per #12916 (#13352)
  Dismissible-notices: fix text overlapping icon (X) (#13371)
  Framework: Remove 5.0-merged REST API integrations (#13408)
  Plugin: Remove 5.0-merged block registration functions, integrations (#13412)
  Framework: Bump minimum required WP to 5.x (#13370)
  [Mobile] Improve keyboard hide button (#13415)
  Improve castError handling of non strings (#13315)
  Fix: File block add custom class (#13432)
  Consider making Fullscreen Mode effects visible only on larger screens (#13425)
  Update plugin version to 4.9.0 (#13436)
  DateTimePicker: fix prop warning for (#12933)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment