Skip to content

Backport r57804 from wp-dev.#59767

Merged
andrewserong merged 1 commit into
trunkfrom
fix/59766-font-face-rest-controller-wp-backport
Mar 12, 2024
Merged

Backport r57804 from wp-dev.#59767
andrewserong merged 1 commit into
trunkfrom
fix/59766-font-face-rest-controller-wp-backport

Conversation

@peterwilsoncc

@peterwilsoncc peterwilsoncc commented Mar 12, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

What?

Backport r57804 from wp-dev.

Fixes #59766
See https://core.trac.wordpress.org/ticket/60741
Backports WordPress/wordpress-develop#6242

Why?

  • Applies consistency with the wp-dev endpoint
  • Hardens the endpoint and removes unneeded overrides from the endpoint.

How?

Copy and paste of the changes.

Testing Instructions

  1. Open Font Library upload model
  2. Ensure uploading a font from your local computer succeeds
  3. Ensure installing a font from Google succeeds.

Testing Instructions for Keyboard

Screenshots or screencast

@github-actions

github-actions Bot commented Mar 12, 2024 •
edited
Loading

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: peterwilsoncc <peterwilsoncc@git.wordpress.org>
Co-authored-by: andrewserong <andrewserong@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@peterwilsoncc peterwilsoncc added [Type] Task Issues or PRs that have been broken down into an individual action to take Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core labels Mar 12, 2024
@peterwilsoncc peterwilsoncc added this to the Gutenberg 17.9 milestone Mar 12, 2024
@peterwilsoncc peterwilsoncc added [Type] WP Core Ticket Requires an upstream change from WordPress. Core Trac ticket should be linked. and removed [Type] Task Issues or PRs that have been broken down into an individual action to take [Type] WP Core Ticket Requires an upstream change from WordPress. Core Trac ticket should be linked. labels Mar 12, 2024
@peterwilsoncc peterwilsoncc added the props-bot Manually triggers Props Bot to ensure the list of props is up to date. label Mar 12, 2024
@github-actions github-actions Bot removed the props-bot Manually triggers Props Bot to ensure the list of props is up to date. label Mar 12, 2024
andrewserong
andrewserong approved these changes Mar 12, 2024
View reviewed changes

@andrewserong andrewserong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the backport! This is testing well for me in uploading a local file and in installing a font from Google Fonts 👍

I see the milestone has been set to Gutenberg 17.9. I'll merge this PR in, and then cherry pick it into the 17.9 release, as that Gutenberg version is due to go out in the next day or so.

@andrewserong andrewserong added [Feature] Font Library [Type] Code Quality Issues or PRs that relate to code quality Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) and removed [Type] Code Quality Issues or PRs that relate to code quality labels Mar 12, 2024
@andrewserong andrewserong merged commit 183a7cf into trunk Mar 12, 2024
@andrewserong andrewserong deleted the fix/59766-font-face-rest-controller-wp-backport branch March 12, 2024 04:28
@andrewserong andrewserong mentioned this pull request Mar 12, 2024
Closed
@andrewserong

andrewserong commented Mar 12, 2024

Copy link
Copy Markdown
Contributor

I just cherry-picked this PR to the release/17.9 branch to get it included in the next release: 4ad39ab

andrewserong added a commit that referenced this pull request Mar 12, 2024
@peterwilsoncc @andrewserong
Font Library: Backport r57804 from wp-dev. (#59767)
4ad39ab 
Co-authored-by: peterwilsoncc <peterwilsoncc@git.wordpress.org>
Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
@andrewserong andrewserong removed the Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) label Mar 12, 2024
carstingaxion pushed a commit to carstingaxion/gutenberg that referenced this pull request Mar 27, 2024
@peterwilsoncc @andrewserong @carstingaxion
Font Library: Backport r57804 from wp-dev. (WordPress#59767)
53d259b 
Co-authored-by: peterwilsoncc <peterwilsoncc@git.wordpress.org>
Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewserong andrewserong andrewserong approved these changes
@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner
@matiasbenedetto matiasbenedetto Awaiting requested review from matiasbenedetto
@creativecoder creativecoder Awaiting requested review from creativecoder

Assignees

No one assigned

Labels

Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core [Feature] Font Library

Projects

None yet

Milestone

Gutenberg 17.9

Development

Successfully merging this pull request may close these issues.

Merge REST API font face controller hardening from WP-Dev

2 participants

@peterwilsoncc @andrewserong