Conversation
scruffian
requested review from
ajitbohra,
ellatrix,
fabiankaegy,
juanmaguitar,
ndiego,
ryanwelcher and
tellthemachines
as code owners
August 13, 2024 09:43
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
scruffian
commented
Aug 13, 2024
| } | ||
| ); | ||
| return select( editorStore ).getDeviceType(); | ||
| return select( blockEditorStore ).getDeviceType(); |
Contributor
Author
There was a problem hiding this comment.
I assume I need to create a new deprecation rather than updating this.
Contributor
Can you detail why we need to change the "device" when triggering zoom-out (how as well) |
Contributor
|
Another question: What should happen when you leave "browse styles", should you go back to "mobile" (in the video you shared)? |
|
Size Change: +119 B (+0.01%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
Contributor
Author
Because when zoom out is triggered the preview becomes quite small, so it makes sense to keep the desktop view. We don't offer zoomed out and mobile as an option in the device previews.
Probably yes - we can do that if this approach makes sense, but I wanted to get clarity on the path before proceeding too far down it! |
Contributor
|
I'm thinking that maybe before doing a big change like this one we can try something smaller. What if |
Contributor
Author
Good idea! Trying that here: #64476 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Moves the deviceType store setting from the editor store to the block editor store.
Fixes #64256.
Why?
We need to change the device preview type in the zoom out hook, which means it needs to be in the block editor store, not the editor store.
How?
Moving the code around. I've not done the cleanup in case this is a bad idea.
Testing Instructions
Screenshots or screencast
Screen.Recording.2024-08-13.at.10.42.37.mov