Audio: Show notice when inserting a non-audio URL in the Audio block#69188
Open
im3dabasia wants to merge 2 commits intoWordPress:trunkfrom
Open
Audio: Show notice when inserting a non-audio URL in the Audio block#69188im3dabasia wants to merge 2 commits intoWordPress:trunkfrom
Audio block#69188im3dabasia wants to merge 2 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #32456
What?
This PR adds a validation check when a URL is inserted into the Audio block. If the URL is not a valid audio file, a warning notice is displayed, informing the user that the file is not supported.
Why?
How?
isValidAudioFile()function that verifies whether a given URL points to a playable audio file.onSelectURL()to check the validity of the URL before setting it in the block.createErrorNotice()snackbar is displayed with an appropriate message.Efficient Audio Validation
Audio()withpreload="metadata"instead of the default auto to prevent unnecessary download.oncanplayfires as soon as metadata is available, ensuring a quick check, unlikeoncanplaythrough, which buffers more data.onerror.Testing Instructions
Screencast
Screen.Recording.2025-02-13.at.5.53.26.PM.mov