wp-build: stop writing worker-code.ts into src/ during build#76118
Closed
ramonjd wants to merge 3 commits into
Closed
wp-build: stop writing worker-code.ts into src/ during build#76118ramonjd wants to merge 3 commits into
ramonjd wants to merge 3 commits into
Conversation
|
Size Change: -10 B (0%) Total Size: 7.73 MB 📦 View Changed
|
|
Flaky tests detected in 31297b9. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/22654488865
|
The vips build was writing the bundled worker content into src/worker-code.ts, which the file watcher detected as a source change and triggered an infinite rebuild loop. Instead, write build-module/worker-code.mjs directly after the worker bundle is built, and add a createWorkerCodeExternalPlugin that short-circuits esbuild's filesystem resolution of ./worker-code imports during transpilation. A committed worker-code.d.ts stub in src/ satisfies TypeScript without any generated file touching the watched directory.
Add the src/worker-code.d.ts type stub to @wordpress/video-conversion, which adopted the wpWorkers pipeline after this branch was written. Remove the tools/build-scripts worker placeholder generation step: the committed type stubs satisfy TypeScript directly, so nothing needs to write worker-code.ts into src/ anymore.
ramonjd
force-pushed
the
try/build-worker-code
branch
from
July 18, 2026 01:21
31297b9 to
aa7d710
Compare
Member
Author
|
Fixed in #80361 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
This is just a test to see if the build works.
The vips build was writing the bundled worker content into src/worker-code.ts, which the file watcher detected as a source change and triggered an infinite rebuild loop.
Instead, write build-module/worker-code.mjs directly after the worker bundle is built, and add a createWorkerCodeExternalPlugin that short-circuits esbuild's filesystem resolution of ./worker-code imports during transpilation. A committed worker-code.d.ts stub in src/ satisfies TypeScript without any generated file touching the watched directory.
What?
Closes
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast