Tab Menu Item: simplify active tab menu item style#77195
Merged
Conversation
t-hamano
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -410 B (-0.01%) Total Size: 7.74 MB 📦 View Changed
ℹ️ View Unchanged
|
|
Flaky tests detected in 08c0b77. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/24393664183
|
mikachan
reviewed
Apr 9, 2026
Member
mikachan
left a comment
mikachan
left a comment
There was a problem hiding this comment.
This is working as described 🙌
I think the core block should offer the most primitive style possible.
I agree, and I think using a border with currentColor is a good way to achieve this.
It looks like the Tabs Menu block.json is still declaring a style path, should this be removed? ("style": "file:./style-index.css")
Contributor
|
Couldn't we just make use of the @current state and style it using that? |
Contributor
Author
Nice idea, I'd like to try that approach in a follow-up. |
mikachan
approved these changes
Apr 14, 2026
Member
mikachan
left a comment
mikachan
left a comment
There was a problem hiding this comment.
Thanks for the changes! This looks good to me. It would be great to try @current in a follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #75731 (comment)
What?
Try to improve the styling of the active tab to make it work better in more contexts.
Why?
The current active tab has its color and background color hardcoded. This can lead to the active tab menu item being invisible depending on the theme's background color. I think the core block should offer the most primitive style possible.
How?
In this PR, I tried a style that is as simple as possible and independent of context. Below the active tab menu item, draw a 2px border with a color equivalent to the text color.
I used pseudo-elements for two main reasons:
Testing Instructions
To ensure the styles are correctly tested, it's probably best to delete the
builddirectory once. Otherwise, the deletedtabs-menu/style.scssmight be applied unintentionally.Screenshots or screencast
For TT5, the focus style is as follows.
Focused:
Active and focused:
Use of AI Tools
None