Link: Fix focus outline around the new-tab icon#77910
Merged
Merged
Conversation
The `.link-icon` is `inline-block` to scope the link underline to the text, but that also lets its line-height (inherited as ~1.5) push the parent anchor's line box taller around the arrow, making the focus outline noticeably taller on that side. Constraining the icon to `line-height: 1` keeps its box within the surrounding text's strut so the outline stays uniform without changing the markup. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
t-hamano
force-pushed
the
fix/ui-link-focus-ring
branch
from
e2b237e to
2404f86
Compare
t-hamano
changed the title
t-hamano
changed the title
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +9 B (0%) Total Size: 7.87 MB 📦 View Changed
ℹ️ View Unchanged
|
mirka
approved these changes
May 4, 2026
Member
mirka
left a comment
mirka
left a comment
There was a problem hiding this comment.
Thanks for fixing 🙏
For posterity, common.css needs to be loaded for this to reproduce in Storybook.
|
Flaky tests detected in 2404f86. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/25314737567
|
Contributor
|
@mirka Should we bolster the Global Defense styles to prevent this override, too? |
Member
|
In this case, the issue was triggered by a 1.4 em line-height on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #77420
What?
Fix the uneven focus outline rendered around
Linkcomponents whenopenInNewTabis enabled.Why?
The link icon has
display:inline-block, which may cause the resulting inline block box to be taller than the surrounding text's baseline.How?
Add
line-height: 1to.link-iconso its box stays within the parent's strut.P.S. Separately from this PR, we also need to fix the focus outline for the
ExternalLinkcomponent. See #77790 (comment)Testing Instructions
Linkstory rendered withopenInNewTabset totrue.Screenshots or screencast
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 4.7
Used for: Diagnosing the root cause (inline-block line-box expansion) and proposing the one-line CSS fix. Final change reviewed and validated by me.