ExternalLink: Fix focus outline under wp-admin#77935
Merged
Merged
Conversation
The wp-admin `common.css` applies `box-shadow` and `border-radius` to focused links, which clashes with the design system focus outline on `ExternalLink`. Override these so the focus indicator renders correctly within wp-admin. Also set `line-height: 1` on the new-tab icon to keep the outline tight around the link content. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
t-hamano
changed the title
|
Size Change: +27 B (0%) Total Size: 7.94 MB 📦 View Changed
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ciampo
reviewed
May 5, 2026
|
Flaky tests detected in ae1165c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/25377503986
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #77910
See #77790 (comment)
What?
Fix the focus outline rendered around the
ExternalLinkcomponent when used inside wp-admin.Why?
#77790 applied a new focus style to the
ExternalLinkcomponent via theoutlineproperty, based on the new design system. However, w-admin appliesbox-shadowandborder-radiusto theaelement, which prevents the focus ring from being formed correctly.Additionally, the link icon has
display:inline-block, which may cause the resulting inline block box to be taller than the surrounding text's baseline.How?
box-shadowandborder-radiusin the focus state so only the design-system outline is shown.line-height: 1to.components-external-link__iconso the icon's inline box stays within the surrounding strut.Testing Instructions
ExternalLink(for example, insert a block, open the Advanced panel, and focus the "Learn more about anchors" link).Screenshots or screencast
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 4.7
Used for: Diagnosing the wp-admin
common.cssoverrides and drafting the CSS fix. Final change reviewed and validated by me.