[codex] Dashboard: Move Howdy greeting into welcome widget - #79699
Draft
scruffian wants to merge 1 commit into
Draft
[codex] Dashboard: Move Howdy greeting into welcome widget#79699scruffian wants to merge 1 commit into
scruffian wants to merge 1 commit into
Conversation
|
Size Change: 0 B Total Size: 7.61 MB |
|
Flaky tests detected in 6b559b7. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/28453328013
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Moves the personal "Howdy" greeting out of the experimental Dashboard page title and into the bundled Welcome widget as the widget's visible
h2heading.Why?
The Dashboard page
h1should identify the page topic. A personal greeting works better inside the Welcome widget, where it can label that widget section while preserving the page-level heading as "Dashboard".How?
hasOwnHeadingwidget metadata flag so a full-bleed widget can provide the heading that labels its widget region.titleIdthrough render props for widgets that opt into owning their heading.Howdy, {display name}as anh2inside anhgroup, with the previous welcome/version copy as paragraphs.h2labels its region.Fixes #79240.
Testing Instructions
npm run test:unit packages/widget-dashboard/src/test/widget-dashboard.test.tsx -- --runInBandnpm run lint:js -- packages/widget-primitives/src/types.ts packages/widget-primitives/src/components/widget-render/widget-render.tsx packages/widget-dashboard/src/components/widget-frame/widget-frame.tsx packages/widget-dashboard/src/components/widget-render/widget-render.tsx packages/widget-dashboard/src/test/widget-dashboard.test.tsx widgets/welcome/components/banner/banner.tsx widgets/welcome/render.tsx widgets/welcome/widget.tsnpm run lint:css -- widgets/welcome/components/banner/banner.module.cssnpm run lint:lockfilenpm run lint:depsnpm run lint:pkg-jsonnpm run build -- --webpack-no-externals --webpack-copy-php --webpack-bundle-analyzer=false --packages=widget-dashboard,widget-primitivesBrowser testing was not completed in this workspace because
wp-env startcannot connect to Docker (Cannot connect to the Docker daemon at unix:///Users/ben/.docker/run/docker.sock).