Fix: Content Guidelines: UX/UI Accessibility issues - #80306
Conversation
…ock guideline at once
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Thanks @hbhalodia - this looks really nice, and it's a good start on the list. One doubt on the
@joedolson the issue suggested either making the label visible or pointing cc @jasmussen for the visual side. |
|
It seems this could better use feedback possibly by @WordPress/gutenberg-components. On the visuals, I'd suggest simpler CTAs: "Save" and "Clear", instead of repeating the "guidelines" term. And should they be right-aligned, with the primary button rightmost so it's the 2nd focus stop? |
|
@hbhalodia To help prioritize, can you tell me whether this is something that needs to be backported to 7.1 or not? |
|
Hi @mirka, I do not think so this should be backported to Thanks, |
|
This feature is not included in 7.1, so this PR should not be backported. |

What?
Part of #80280
Why?
How?
PR fixes the issues that are shared in the mentioned issue.
Currently Fixed issues in the PR
labelvisible or usingaria-labelledbypointing to the existing visible text.aria-pressed, which isn't the appropriate ARIA status; it should havearia-haspopupwith a value ofdialog, instead.table with 1 row and 2 columns row 1 column 1 Paragraph toggle button pressed; this is because the button is inside agridrole, which forces a lot of excess semantics. Given the simplicity of this structure, I don't think that this is an appropriate organization.aria-labelis 'Import Guidelines', and the visual text is 'Upload'.aria-labelis "Export Guidelines" and the visual text is 'Download'.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Focus lost fix
Screen.Recording.2026-07-15.at.3.46.34.PM.mov
Use of AI Tools