Fix hiding a dock-placed native window's tile via Apps & Icons - #407
Merged
Merged
Conversation
Native windows registered with placement 'dock' (Games) render as system tiles, which bypassed the itemVisibility overrides entirely: hiding the item removed the wallpaper icon but the dock tile stayed. The layout dispatcher now resolves each system tile's visibility (keyed by the desktop icon targeting its window, falling back to the tile id) and attaches/detaches tiles live on every settings save. Fixes #405 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WCknM6zk6JS14pdLUiqdRR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #405
Native windows registered with
placement: 'dock'(Games) render as system tiles, which bypassed the Apps & IconsitemVisibilityoverrides — hiding the item removed the wallpaper icon but the dock tile stayed.The layout dispatcher now resolves each system tile's visibility (keyed by the desktop icon targeting its window, falling back to the tile id; no override = visible, so OS Settings / Recycle Bin tiles are untouched) and attaches/detaches tiles live on settings saves, boot, and layout rebuilds. "On the desktop" now also removes the dock tile; "On the dock" / "On both" keep it.
src/desktop-layout.ts— visibility-aware system-tile reconciletests/vitest/desktop-layout.test.ts— 5 regression testsdocs/javascript-reference.md—fullSystemTilesrow updated🤖 Generated with Claude Code
https://claude.ai/code/session_01WCknM6zk6JS14pdLUiqdRR