Skip to content

Prevent typescript error#12370

Closed
aaronjorbin wants to merge 1 commit into
WordPress:7.0from
aaronjorbin:fix/7-0-build-typescript
Closed

Prevent typescript error#12370
aaronjorbin wants to merge 1 commit into
WordPress:7.0from
aaronjorbin:fix/7-0-build-typescript

Conversation

@aaronjorbin

Copy link
Copy Markdown
Member

Fix https://github.com/WordPress/wordpress-develop/actions/runs/28473169099

AI: Consulted with ChatGPT about the error, I wrote the code.

@github-actions

Copy link
Copy Markdown

Hi there! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

pento pushed a commit that referenced this pull request Jun 30, 2026
Backporting [62600] leads to the following error: `Parameter 'dep' implicitly has an 'any' type.` so this gives an explicit type and also does explicit type checking.

This isn't an issue in trunk due to [62428] removing this code and re-introducing client side media so this commit is only happening in the 7.0 branch.

Developed in: #12370
Discussed in slack thread: https://wordpress.slack.com/archives/C02RQBWTW/p1782850291418919

Follow up-to [62600].

Props jorbin, joedolson.
See: #65452.


git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62604 602fd350-edb4-49c9-b593-d223f7449a82
@aaronjorbin

Copy link
Copy Markdown
Member Author

markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Jun 30, 2026
Backporting [62600] leads to the following error: `Parameter 'dep' implicitly has an 'any' type.` so this gives an explicit type and also does explicit type checking.

This isn't an issue in trunk due to [62428] removing this code and re-introducing client side media so this commit is only happening in the 7.0 branch.

Developed in: WordPress/wordpress-develop#12370
Discussed in slack thread: https://wordpress.slack.com/archives/C02RQBWTW/p1782850291418919

Follow up-to [62600].

Props jorbin, joedolson.
See: #65452.

Built from https://develop.svn.wordpress.org/branches/7.0@62604


git-svn-id: http://core.svn.wordpress.org/branches/7.0@61884 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants