Better guide users when deleting other users in single- and multisites; copy 10502#12467
Closed
joedolson wants to merge 41 commits into
Closed
Better guide users when deleting other users in single- and multisites; copy 10502#12467joedolson wants to merge 41 commits into
joedolson wants to merge 41 commits into
Conversation
…checked in user deletion form
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Refactor the IIFE structure and remove unnecessary code.
…0.0 in `deprecated.php`.
…sing list item tag
…nd providing accessible error summaries. This update ensures that users cannot be deleted without a valid reassignment target, improving both functionality and accessibility for assistive technologies.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
ocean90
approved these changes
Jul 10, 2026
ocean90
left a comment
ocean90
left a comment
Member
There was a problem hiding this comment.
Thank you @joedolson and @afercia! This is now looking very good!
Do you want to bring this over the finish line so it can be part of 7.1? Happy to do so otherwise.
Contributor
Author
|
I've got it on my todo list to commit today, so I can go ahead and take care of it! |
joedolson
commented
Jul 10, 2026
pento
pushed a commit
that referenced
this pull request
Jul 10, 2026
Provide clearer guidance for reassigning or deleting content when deleting users in both single and multisite instances. Content assignment is handled on a per-user basis, rather than forcing all content to be assigned to a single user. Add validation to enforce making a selection. Add fieldsets and legends to improve form structure and accessibility. Move inline JS to `common.js`. Improve backend logic to process per-user content handling. Exclude users being deleted from dropdown forms. Developed in #10502, #12467 Props stefan.velthuys, ocean90, hellofromTonya, akshat2802, hubersen, fakhriaz, ozgursar, sirlouen, realloc, audrasjb, joedolson, afercia, krokodok. Fixes #56914. git-svn-id: https://develop.svn.wordpress.org/trunk@62688 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Jul 10, 2026
Provide clearer guidance for reassigning or deleting content when deleting users in both single and multisite instances. Content assignment is handled on a per-user basis, rather than forcing all content to be assigned to a single user. Add validation to enforce making a selection. Add fieldsets and legends to improve form structure and accessibility. Move inline JS to `common.js`. Improve backend logic to process per-user content handling. Exclude users being deleted from dropdown forms. Developed in WordPress/wordpress-develop#10502, WordPress/wordpress-develop#12467 Props stefan.velthuys, ocean90, hellofromTonya, akshat2802, hubersen, fakhriaz, ozgursar, sirlouen, realloc, audrasjb, joedolson, afercia, krokodok. Fixes #56914. Built from https://develop.svn.wordpress.org/trunk@62688 git-svn-id: http://core.svn.wordpress.org/trunk@61972 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a copy of #10502 with changes applied from @afercia and my own reviews, because I was unable to merge to that PR.
It does not include the switch of strings to use
_n(), as I'm not convinced that the churn in strings is helpful.Trac ticket: https://core.trac.wordpress.org/ticket/56914
Use of AI Tools
None
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.