Skip to content

KSES: Add tabindex to the list of allowed global attributes.#12493

Closed
t-hamano wants to merge 2 commits into
WordPress:trunkfrom
t-hamano:65619-kses-allow-tabindex-global-attribute
Closed

KSES: Add tabindex to the list of allowed global attributes.#12493
t-hamano wants to merge 2 commits into
WordPress:trunkfrom
t-hamano:65619-kses-allow-tabindex-global-attribute

Conversation

@t-hamano

Copy link
Copy Markdown
Contributor

Use of AI Tools

The AI implemented it, and then I reviewed everything myself.

The tabindex attribute was previously stripped from post content for users without the unfiltered_html capability, which breaks blocks that rely on a roving tabindex, such as the Tabs block.

Fixes #65619.

Co-Authored-By: Claude <noreply@anthropic.com>
@t-hamano t-hamano marked this pull request as ready for review July 13, 2026 08:02
@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props wildworks, ramonopoly.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@ramonjd ramonjd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


Just flagging a ref I found for _wp_add_global_attributes. Some of the same attributes are used for <math /> - tabindex is valid.

But no-one is asking for it and it's beyond the scope of this PR. 😄

Comment thread src/wp-includes/kses.php Outdated
pento pushed a commit that referenced this pull request Jul 13, 2026
Add `tabindex` to the list of global attributes allowed by `_wp_add_global_attributes()`, so it survives KSES filtering on any element that supports global attributes.

Developed in: #12493

Props ramonopoly, wildworks.
Fixes #65619.


git-svn-id: https://develop.svn.wordpress.org/trunk@62708 602fd350-edb4-49c9-b593-d223f7449a82
@github-actions

Copy link
Copy Markdown

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 62708
GitHub commit: d6f6780

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions Bot closed this Jul 13, 2026
markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Jul 13, 2026
Add `tabindex` to the list of global attributes allowed by `_wp_add_global_attributes()`, so it survives KSES filtering on any element that supports global attributes.

Developed in: WordPress/wordpress-develop#12493

Props ramonopoly, wildworks.
Fixes #65619.

Built from https://develop.svn.wordpress.org/trunk@62708


git-svn-id: http://core.svn.wordpress.org/trunk@61992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants