Fix the checkboxes alignment - #12803
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
Thanks @joedolson for the mention and @3kori for the ticket/pr! I've checked this on a fresh 7.0.2 install and couldnt find that issue - it works perfectly there. Would be good to know what created this regression to doublecheck if anything else is affected. @3kori did you check already? Though i was able to replicate it on Beta4: As well i can confirm it works now for both Erase and Export Requests: But i'd want to be sure we dont break the other Patch when we add this. |
|
I'm seeing a blue highlight on the column-title in your second screenshot, @masteradhoc; that probably needs to be moved to the The regression came from the list-table changes in https://core.trac.wordpress.org/ticket/32892. |
|
The new commit fixes the issue; I was busy working on another commit in another direction. Also, I think the confirmed check-box border-left-color should be using the new admin-skin color: #3858e9 |
|
The previous color used for Also making the same change for |
Adjust styling on privacy export and erasure tables for compatibility with the list table column changes in [62839]. Update the colors used to highlight confirmed or failed privacy requests following the admin color scheme changes in WordPress 7.0. Developed in #12803 Props r1k0, joedolson, masteradhoc, shailu25. Fixes #65787. git-svn-id: https://develop.svn.wordpress.org/trunk@63010 602fd350-edb4-49c9-b593-d223f7449a82
Adjust styling on privacy export and erasure tables for compatibility with the list table column changes in [62839]. Update the colors used to highlight confirmed or failed privacy requests following the admin color scheme changes in WordPress 7.0. Developed in WordPress/wordpress-develop#12803 Props r1k0, joedolson, masteradhoc, shailu25. Fixes #65787. Built from https://develop.svn.wordpress.org/trunk@63010 git-svn-id: http://core.svn.wordpress.org/trunk@62229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
Great catch @3kori and thanks for the fast implementation @joedolson. That looks good on both erasure and export requests:
The color is now the correct one |










This corrects the check boxes misalignment issue in the export/erase personal data tables.
Trac ticket: 65787
Use of AI Tools
N/A
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.