Skip to content

Fix the checkboxes alignment - #12803

Open
3kori wants to merge 4 commits into
WordPress:trunkfrom
3kori:fix/65787
Open

Fix the checkboxes alignment#12803
3kori wants to merge 4 commits into
WordPress:trunkfrom
3kori:fix/65787

Conversation

@3kori

@3kori 3kori commented Aug 2, 2026

Copy link
Copy Markdown

This corrects the check boxes misalignment issue in the export/erase personal data tables.

Trac ticket: 65787

Use of AI Tools

N/A


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props r1k0, joedolson, masteradhoc, shailu25.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@3kori

3kori commented Aug 2, 2026

Copy link
Copy Markdown
Author

Before:

desktop-view-checkbox-before

After:

desktop-view-checkboxes-after
Viewport Before After
> 768 ❌ Misaligned ✅ Aligned
< 768 ❌ Misaligned ✅ Aligned

@masteradhoc

Copy link
Copy Markdown

Thanks @joedolson for the mention and @3kori for the ticket/pr!

I've checked this on a fresh 7.0.2 install and couldnt find that issue - it works perfectly there. Would be good to know what created this regression to doublecheck if anything else is affected. @3kori did you check already?

Though i was able to replicate it on Beta4:
image

As well i can confirm it works now for both Erase and Export Requests:
image
image

But i'd want to be sure we dont break the other Patch when we add this.

@joedolson

Copy link
Copy Markdown
Contributor

I'm seeing a blue highlight on the column-title in your second screenshot, @masteradhoc; that probably needs to be moved to the check-column cell.

The regression came from the list-table changes in https://core.trac.wordpress.org/ticket/32892.

@joedolson

Copy link
Copy Markdown
Contributor

Confirmed that the border also needs to change:

Confirmed request in 7.0:

image

@3kori

3kori commented Aug 3, 2026

Copy link
Copy Markdown
Author

The new commit fixes the issue; I was busy working on another commit in another direction.
I was to use styling similar to that of the plugins table:
normal check-boxes -> padding-left: 6px
confirmed/failed check-boxes -> padding-left: 2px, border-left: 4px solid #fff

Also, I think the confirmed check-box border-left-color should be using the new admin-skin color: #3858e9

@shail-mehta

Copy link
Copy Markdown
Member

Alignment Issue is Resolved✅

Before After
before-patch after-patch

@joedolson

Copy link
Copy Markdown
Contributor

The previous color used for .status-request-confirmed was the same color as in .notice-info, so that's a reasonable switch.

Also making the same change for .status-request-failed, using the color for .notice-error.

pento pushed a commit that referenced this pull request Aug 4, 2026
Adjust styling on privacy export and erasure tables for compatibility with the list table column changes in [62839]. 

Update the colors used to highlight confirmed or failed privacy requests following the admin color scheme changes in WordPress 7.0.

Developed in #12803

Props r1k0, joedolson, masteradhoc, shailu25.
Fixes #65787.

git-svn-id: https://develop.svn.wordpress.org/trunk@63010 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Aug 4, 2026
Adjust styling on privacy export and erasure tables for compatibility with the list table column changes in [62839]. 

Update the colors used to highlight confirmed or failed privacy requests following the admin color scheme changes in WordPress 7.0.

Developed in WordPress/wordpress-develop#12803

Props r1k0, joedolson, masteradhoc, shailu25.
Fixes #65787.
Built from https://develop.svn.wordpress.org/trunk@63010


git-svn-id: http://core.svn.wordpress.org/trunk@62229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
@masteradhoc

Copy link
Copy Markdown

Great catch @3kori and thanks for the fast implementation @joedolson.

That looks good on both erasure and export requests:

image image

The color is now the correct one #3858e9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants