chore(spawn-docker, spawn-local-platform): extend TelemetryRecorder plumbing to Docker sessions and LocalMachine - #58
Merged
Merged
Conversation
…lumbing to Docker sessions and LocalMachine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The base-telemetry migration in a prior commit added
TelemetryRecordersupport to the core platform types, but the Docker session hierarchy andLocalMachinestill only recorded telemetry via a hardcodedSystemTelemetryRecorder, andBuildImage/GetSystemEventsconstructed a defaultJsonNodeInputStreamProcessorthat wrote straight toSystem.out/System.errinstead of routing through an injectable recorder.This change adds a
TelemetryRecorderFactory-accepting constructor alongside the existing no-arg-telemetry constructor onAbstractSession,TCPSocketBasedSession, andUnixDomainSocketBasedSession, and threads an@Inject-edTelemetryRecorderFactoryfield throughDockerHostVariableBasedSessionFactory,InternalDockerHostBasedSessionFactory,LocalHostBasedSessionFactory, andUnixDomainSocketBasedSession.Factoryso each produces sessions bound to the caller-supplied recorder.Sessions.factoriesandSessions.createSessiongained overloads that accept aTelemetryRecorderFactoryand bind it into the discoveryContext, defaulting toSystemTelemetryRecorder::ofwhen omitted.AbstractCommandnow exposes arecorder()accessor backed by an injectedTelemetryRecorder, andBuildImage/GetSystemEventspass it intoJsonNodeInputStreamProcessorinstead of relying on its default constructor.LocalMachinegained a matchingTelemetryRecorderFactory-accepting constructor that forwards toAbstractTemplatedPlatform.spawn-docker'smodule-info.javaandpom.xmlnow declarebase-telemetryandbase-telemetry-foundationdependencies, andspawn-local-platformpicks upbase-telemetry-foundationfor the same reason.