UI elements for crowdfunding campaigns#541
Closed
pranshuchittora wants to merge 2 commits intoWorldBrain:developfrom
Closed
UI elements for crowdfunding campaigns#541pranshuchittora wants to merge 2 commits intoWorldBrain:developfrom
pranshuchittora wants to merge 2 commits intoWorldBrain:developfrom
Conversation
Contributor
Author
|
Help me with the popup (Is it same as this & How to call it ) |
poltak
reviewed
Aug 28, 2018
| .shareIcon { | ||
| box-sizing: border-box; | ||
| background-image: url('/img/share.svg'); | ||
| background-repeat: no-repeat; |
Member
There was a problem hiding this comment.
Just a quick note: all these icon classes repeat a similar set of rules. Rather than repeating them in each class, create a common class with the shared rules which you can apply to all of the icon elements
Contributor
Author
|
Just refactored the |
Member
|
superseeded by #558. Thanks @pranshuchittora for the starter :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#540
