Annotations Crowdfunding UI.#558
Conversation
|
I really don't like the way 77ca94e solves the modal closing issue, mainly because it's now accessing the real DOM from within the React DOM, but also because it's coupling the crowdfunding modal-related logic with the sidebar stuff. @oliversauter @digi0ps Are the main remaining things now (at least to address #540):
anything else? |
|
don't fully get what the problem with the modal closing is? works for me quiet well? Problems I found:
@mukeshkharita can you work on the analytics here, and add analytics to the following actions:
|
@poltak Yeah, not the best way to prevent the closing of sidebar. But the two were in very different modules, using refs would involve lot of passing down of props. So had to go for this way. |
3f6937a to
0062d2f
Compare
Previously, it closed the sidebar too.
0062d2f to
0bffb89
Compare
- also moved to TS - these two components duplicate a lot of code; it would be nice to DRY them out eventually - also fixed up crowdfunding button defined check

Brought up a quick working modal for both CrowdFunding Box and Overview Modal.
Forked from #541. Thanks to @pranshuchittora for his work (# on icons and refactoring Annotations CSS.
Related to #540 #552.