Merged
Conversation
Otherwise the last assert in the test is not done.
This reverts commit 7899935.
RSH1a New push.admin.publish
RHS1b3 New push.admin.device_registrations.save
New RSH1b1 New push.admin.device_registrations.get
list is a reserved word, so we use list_
RSH1b2 New push.admin.device_registrations.list_
RSH1b4 New push.admin.device_registrations.remove
The dev environments don't work with push.
This reverts commit 6f85b9f.
RSH1c3 New push->admin->channelSubscriptions->save
list is a reserved word
RSH1c1 New push->admin->channelSubscriptions->list_
RSH1c2 push->admin->channelSubscriptions->listChannels
RSH1c4 and RSH1c5
Contributor
Author
Contributor
Author
|
So now which are the next steps? Should I change this PR to Ready for review? |
Member
Yes. And @paddybyers or I can merge / approve etc. Thanks,. |
Member
|
Merged, thanks, should we do a release @jdavid? |
Member
|
@tomczoink in case anything needs updating in the docs, looks like Push is now supported! 👍 |
Contributor
Author
|
@mattheworiordan yes I think so, 1.1.2 ? |
Member
Sure, if that's the next patch release version. Please confirm when done. Thanks 🙏 |
Contributor
Author
Member
|
Awesome, tahnks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up from #79
This is a feature branch, all changes have been reviewed already.