PR #60 follow-up fixes - #61
Merged
Merged
Conversation
Member
Author
|
@fredordercloud as the line feed changed for two files, you have to enable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #60.
FileCredentialsignores unknown JSON keys, so the AWS Secrets Manager format withengine,host,portanddbnameworks. The testwhenFileHasExtraKeys_shouldIgnoreThemcovers it.KubernetesServiceTest.javaandFileRef.javaconverted from CRLF to LF, like the rest of the repo.KubernetesServiceand the two test classes, the Jackson import position, and constructor injection for the two config values inClusterConnectionReconcilerTest.has(self.adminSecretRef) != has(self.adminSecretFileRef). Same truth table, shorter.#### File formatas a child of### FileRefin the docs, Javadoc wording fixes, andvarfor theAtomicReference.Not in this PR, they come separately: Helm chart values for
volumesandvolumeMounts, a.gitattributesthat forces LF, and the Error ProneVarifiercheck.