Skip to content

PR #60 follow-up fixes - #61

Merged
ThoSap merged 5 commits into
mainfrom
pr-60-follow-up
Sep 4, 2026
Merged

PR #60 follow-up fixes#61
ThoSap merged 5 commits into
mainfrom
pr-60-follow-up

Conversation

@ThoSap

@ThoSap ThoSap commented Sep 4, 2026

Copy link
Copy Markdown
Member

Follow-up to #60.

  • FileCredentials ignores unknown JSON keys, so the AWS Secrets Manager format with engine, host, port and dbname works. The test whenFileHasExtraKeys_shouldIgnoreThem covers it.
  • KubernetesServiceTest.java and FileRef.java converted from CRLF to LF, like the rest of the repo.
  • Member order in KubernetesService and the two test classes, the Jackson import position, and constructor injection for the two config values in ClusterConnectionReconcilerTest.
  • CEL rule simplified to has(self.adminSecretRef) != has(self.adminSecretFileRef). Same truth table, shorter.
  • #### File format as a child of ### FileRef in the docs, Javadoc wording fixes, and var for the AtomicReference.

Not in this PR, they come separately: Helm chart values for volumes and volumeMounts, a .gitattributes that forces LF, and the Error Prone Varifier check.

@ThoSap ThoSap changed the title Follow-up to #60: ignore unknown keys in the credentials file, LF line endings, member order, simpler CEL rule PR #60 follow-up fixes Sep 4, 2026
@ThoSap

ThoSap commented Sep 4, 2026

Copy link
Copy Markdown
Member Author

@fredordercloud as the line feed changed for two files, you have to enable Hide whitespace in the PR file diff to see the real changes.

@ThoSap ThoSap self-assigned this Sep 4, 2026
@ThoSap
ThoSap merged commit 971582e into main Sep 4, 2026
4 checks passed
@ThoSap
ThoSap deleted the pr-60-follow-up branch September 4, 2026 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant