Enforce LF line endings with .gitattributes - #64
Merged
Conversation
Two files in #60 were committed with CRLF although .editorconfig asks for LF. Git now normalizes every text file to LF on commit and checks it out as LF on every platform, so the editor setting can no longer be bypassed. gradlew.bat keeps CRLF in the working tree. jar and png files are marked binary. Also fix the linguist-generated pattern: the jOOQ sources live under generated/src/, not src/generated/, so the old pattern matched nothing.
stplasim
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two files in #60 arrived with CRLF line endings although
.editorconfigasks for LF..editorconfigonly advises the editor, so a different tool or git client can still commit CRLF. This PR adds the git-side rule.* text=auto eol=lf: every text file is stored with LF and checked out with LF on every platform. Git detects binary files itself.*.bat text eol=crlf:gradlew.batkeeps CRLF in the working tree, as the Gradle wrapper expects.*.jar binary,*.png binary: explicit for the two binary types in the repo.[*.bat] end_of_line = crlfin.editorconfig, matching the git rule.linguist-generatedpattern: the jOOQ sources live undergenerated/src/, notsrc/generated/, so the old pattern matched nothing. Verified withgit check-attr.git add --renormalize .changed no other file, somainhas no CRLF left after #61.