TypeError: argument of type 'NoneType' is not iterable test_apache_tomcat

[ziadhany]

        data = requests.get(url).content
        soup = BeautifulSoup(data, features="lxml")
        for tag in soup.find_all("a"):
            link = tag.get("href")
    
>           if "security-" in link and any(char.isdigit() for char in link):
E           TypeError: argument of type 'NoneType' is not iterable

vulnerabilities/importers/apache_tomcat.py:141: TypeError

[nikkuAg]

Is this issue still open? I want to solve this.

[TG1999]

@nikkuAg thanks for chiming in, sure go ahead. The underlying issue is that the network call is this test is not mocked https://github.com/nexB/vulnerablecode/blob/main/vulnerabilities/tests/test_apache_tomcat.py#L339. Please mock this test with an HTML response.

[nikkuAg]

@TG1999 Can you please elaborate on what do you mean by mock the test with HTML response?

[ziadhany]

@nikkuAg Have a look at this article which simply explains mock external API calls
https://pytest-with-eric.com/pytest-advanced/pytest-mocking/#Mock-External-Rest-API-Calls

[nikkuAg]

So, instead of updating the test_apache_tomcat.py file, we should add error handling in the apache_tomcat.py file.

[ziadhany]

So, instead of updating the test_apache_tomcat.py file, we should add error handling in the apache_tomcat.py file.

@nikkuAg No , we need to add a new mock test in test_apache_tomcat.py file , no need to add error handling in the apache_tomcat.py file.