Convert chromeCookies/chromeNetworkActionPredictor to LAVA (per-browser tables)#731
Merged
Conversation
…rowser tables) Apply the multi-browser pattern: keep each artifact's existing query and rows, generate a per-browser HTML report and per-browser LAVA table for every browser found, and return a combined dataset with a trailing 'Browser Name' column. - chromeCookies: three datetime columns marked; output "standard". - chromeNetworkActionPredictor: no datetime column; output ['html','tsv','lava']. Queries and rows unchanged (structurally verified against main). Function keys dropped since decorated functions resolve by name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues the Chrome-family conversion with the per-browser pattern (#729, #730).
For each browser found, generates a per-browser HTML report and a per-browser LAVA table (
<Browser> - Cookies,<Browser> - Network Action Predictor), then returns a combined dataset with a trailingBrowser Namecolumn for the combined TSV/timeline/LAVA outputs. Browser identified at runtime viaget_browser_name.standard.['html','tsv','lava'].Each artifact's existing query and
data_listrows are unchanged — verified structurally againstmain, so these clear the structural gate in addition to the per-browser restructuring.Verified: both parse, are lint-clean, and the plugin loader resolves them with no warnings. (No test data for these two in available extractions; the per-browser pattern itself was behaviorally confirmed in #729/#730 on a Samsung extraction.)