Convert chromeLoginData to LAVA (per-browser tables)#732
Merged
Conversation
Apply the multi-browser pattern: per-browser HTML report and per-browser LAVA table for every browser found, with a combined dataset returning a trailing 'Browser Name' column. The query and the password decryption (PBKDF2/AES) are unchanged; browser_name, which the original baked into each row, is now added at the combine step so the per-browser tables don't carry a redundant Browser column. Created Time marked as datetime; output "standard". Function key dropped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues the Chrome-family conversion with the per-browser pattern (#729–#731).
For each browser found, generates a per-browser HTML report and a per-browser LAVA table (
<Browser> - Login Data), then returns a combined dataset with a trailingBrowser Namecolumn.browser_nameinto every row; it's now added at the combine step, so each per-browser table doesn't carry a redundant Browser column (consistent with the other Chrome conversions).Created Timemarked asdatetime; outputstandard.Verified: parses, lint-clean, plugin loader resolves with no warnings. (No login-data test rows in available extractions; the per-browser pattern itself was behaviorally confirmed on a Samsung extraction in #729/#730.)