Drop legacy ArtifactHtmlReport from 7 Chromium artifacts#861
Merged
Conversation
These artifacts were already @artifact_processor-decorated and returned a consolidated (all-browsers + Browser Name) result, but ALSO redundantly built a per-browser ArtifactHtmlReport and made manual lava_process_artifact/lava_insert_sqlite_data calls inside the loop. The decorator's wrapper already generates HTML/TSV/timeline/LAVA from the returned data, so the manual blocks produced duplicate per-browser tables and reports. Removed the redundant per-browser report + manual LAVA blocks (and the now-unused imports) from: chromeNetworkActionPredictor, chromeTopSites, chromeOfflinePages, chromeBookmarks, chromeCookies, chromeDIPS, chromeLoginData. Each now emits a single consolidated LAVA table + HTML report with the Browser Name discriminator column. No change to parsing, queries, timestamp handling, or returned data.
stark4n6
pushed a commit
to stark4n6/ALEAPP
that referenced
this pull request
Jun 22, 2026
Same hybrid cleanup as abrignoni#861: both were already @artifact_processor-decorated and returned consolidated (all-browsers + Browser Name) data, but also redundantly built per-browser ArtifactHtmlReport reports and manual lava_process_artifact/lava_insert_sqlite_data tables (chromeAutofill via an _emit_report helper, chromeMediaHistory inline in each of its 3 functions). Removed the redundant per-browser report + manual LAVA blocks (and now-unused imports). Each artifact now emits a single consolidated LAVA table + HTML report with the Browser Name discriminator. No change to parsing, SQL, timestamp handling, or returned data.
stark4n6
pushed a commit
to stark4n6/ALEAPP
that referenced
this pull request
Jun 22, 2026
…ule) Same hybrid cleanup as abrignoni#861/abrignoni#872: the 5 functions (get_chrome, get_chromeWebVisits, get_chromeSearchTerms, get_chromeDownloads, get_chromeKeywordSearchTerms) were already @artifact_processor and returned consolidated (Browser Name) data, but also redundantly built per-browser ArtifactHtmlReport reports + manual lava tables via an _emit helper. Removed _emit and its 5 calls and the now-unused imports. Left get_browser_name, _history_files, and _webkit_to_utc untouched -- get_browser_name is imported by 9 other Chromium artifacts. No change to parsing, SQL, timestamps, or returned data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the legacy
ArtifactHtmlReportdependency from seven Chromium artifacts that were in a hybrid state.The hybrid problem
Each of these was already
@artifact_processor-decorated and returned a consolidated result (all browsers + aBrowser Namediscriminator column). But inside the loop they also redundantly:ArtifactHtmlReport(withget_next_unused_name/.temphtmldynamic naming), andlava_process_artifact+lava_insert_sqlite_datacalls creating a separate per-browser LAVA table.The
@artifact_processorwrapper (scripts/ilapfuncs.py) already generates HTML, TSV, timeline, and LAVA from the returned(data_headers, data_list, source_path). So the manual blocks just produced duplicate per-browser tables/reports alongside the consolidated one.Change
Removed the redundant per-browser report + manual LAVA blocks (and now-unused imports) from:
chromeNetworkActionPredictor,chromeTopSites,chromeOfflinePages,chromeBookmarks,chromeCookies,chromeDIPS,chromeLoginData.Each now emits a single consolidated LAVA table + HTML report with the
Browser Namecolumn — the standard consolidation pattern. No change to parsing, SQL, timestamp conversion, or the returned data.Verification
-d C,R); no leftoverArtifactHtmlReport/lava_process_artifact/lava_insert_sqlite_data/get_next_unused_namereferences.