Drop legacy ArtifactHtmlReport from chrome (base Chromium History module)#878
Merged
Conversation
…ule) Same hybrid cleanup as #861/#872: the 5 functions (get_chrome, get_chromeWebVisits, get_chromeSearchTerms, get_chromeDownloads, get_chromeKeywordSearchTerms) were already @artifact_processor and returned consolidated (Browser Name) data, but also redundantly built per-browser ArtifactHtmlReport reports + manual lava tables via an _emit helper. Removed _emit and its 5 calls and the now-unused imports. Left get_browser_name, _history_files, and _webkit_to_utc untouched -- get_browser_name is imported by 9 other Chromium artifacts. No change to parsing, SQL, timestamps, or returned data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The base Chromium
chrome.py— same hybrid cleanup as #861 / #872.Its 5 functions (
get_chrome,get_chromeWebVisits,get_chromeSearchTerms,get_chromeDownloads,get_chromeKeywordSearchTerms) were already@artifact_processor-decorated and returned consolidated (Browser Name) data, but also redundantly built per-browserArtifactHtmlReportreports + manuallava_process_artifact/lava_insert_sqlite_datatables through a shared_emithelper._emitand its 5 calls, plus the now-unused imports.get_browser_nameuntouched — it's imported by 9 other Chromium artifacts (from scripts.artifacts.chrome import get_browser_name); also kept_history_filesand_webkit_to_utc.Verification
-d C,R); no leftoverArtifactHtmlReport/lava_process_artifact/lava_insert_sqlite_data/get_next_unused_name/_emit; all 5 header sets pass a liveCREATE TABLE.get_browser_namestill importable and correct; PluginLoader 503 (unchanged) — all 5 chrome functions plus the 9 importers still load.