Context-form retrofit (batch 1): downloads, googleCast, walStrings, browserCachechrome#906
Merged
Merged
Conversation
…Strings, browserCachechrome Retrofit these @artifact_processor artifacts from the 4-arg (files_found, report_folder, seeker, wrap_text) form to the single-arg context form, and apply context.get_relative_path() where a full on-disk path was leaking into a data column (cleaner in-extraction paths in LAVA). - Signature -> def fn(context); re-establish files_found = context.get_files_found() (+ report_folder for walStrings). - The 'Source File'/'Source'/'Location' column that held the raw file_found full path now uses context.get_relative_path(file_found). - browserCachechrome also relativizes its dirname source_path return. - Dropped now-unnecessary '# pylint: disable=W0613' headers (no unused args in context form); removed a pre-existing unused logfunc import in googleCast. Logic otherwise unchanged. pylint 10.00.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First batch of the ALEAPP context-form retrofit, scoped to artifacts where
get_relative_pathactually improves output — i.e. a full on-disk path was leaking into a data column (and would otherwise display the examiner's local report path instead of the clean in-extraction path).Change (mechanical, logic unchanged)
(files_found, report_folder, seeker, wrap_text)→ single-argdef fn(context); re-establishfiles_found = context.get_files_found()(+report_folder = context.get_report_folder()for walStrings).Source File/Source/Location) that held the rawfile_foundnow usescontext.get_relative_path(file_found). browserCachechrome also relativizes itsdirnamesource_pathreturn.# pylint: disable=W0613headers (no unused args in context form); removed a pre-existing unusedlogfuncimport in googleCast.Validation
__wrapped__present; pylint 10.00/10.get_relative_pathmechanism verified:/extract/base/data/com.app/x.db→data/com.app/x.db(empty/unset → safe no-op).Scope
This is batch 1 of ~5. I identified 28 artifacts total with a full path in a data column (the clear "improves output" subset, distinct from the ~554 that are merely on the 4-arg form). Same minimal-diff pattern for the rest.