Context-form retrofit (batch 2): browserCachefirefox, NQ_Vault, knuddels, likee#907
Merged
Conversation
…ult, knuddels, likee
Batch 2 of the retrofit (7 functions across 4 files). Same minimal-diff pattern:
4-arg signature -> def fn(context); files_found = context.get_files_found();
the data column / source_path return that held a raw full path now uses
context.get_relative_path(). Logic unchanged; dropped the disable headers.
- browserCachefirefox: 'Source' column + dirname source_path.
- NQ_Vault: get_NQVault (db_path source) + get_NQVault_media ('Full Path' column
+ db_path source).
- knuddels: 'Source File' column.
- likee: get_likee ('Source' column + source), get_likee_users (source),
get_likee_messages (source).
All 7 context form; pylint 10.00.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch 2 of the ALEAPP context-form retrofit (7 functions / 4 files). Same minimal-diff pattern as #906: 4-arg →
def fn(context),files_found = context.get_files_found(), andcontext.get_relative_path()on the path column / source-path return that previously leaked the examiner's full local path.Sourcecolumn +dirnamesource.get_NQVault_mediahas theFull Pathcolumn.Source Filecolumn.get_likeehas the path column; the others get the source-path cleanup).Logic unchanged; dropped the
# pylint: disable=W0613headers. pylint 10.00, all 7 now context form, imports clean, 10get_relative_pathapplications. (22 of 28 artifacts remain.)