chore(deps): drop placeholder crypto npm package - #210
Merged
niallroche merged 1 commit intoJul 21, 2026
Conversation
`server/package.json` listed `crypto@1.0.1` as a runtime dependency. That is not the Node builtin `crypto`; it is a registry stub that npm itself marks as `deprecated: "This package is no longer supported. It's now a built-in Node module. If you've depended on crypto, you should switch to the one that's built-in."`. Bare specifiers for builtin modules resolve to the builtin regardless of what is under `node_modules/`, so the stub was doing nothing at install time except wasting a network round-trip and confusing anyone reading the manifest. Confirmed the one existing `import * as crypto from 'crypto'` call site (`handlers/mcp.ts:7`) still resolves to the Node builtin. All 91 server tests pass after removal. Lock-file diff is scoped to the removed entry; no other deps bumped. Signed-off-by: Jay Guwalani <guwalanijj@gmail.com>
niallroche
self-requested a review
July 21, 2026 08:15
niallroche
approved these changes
Jul 21, 2026
🎉 Thank you for your contribution! 🎉Dear @JayDS22, Your pull request has been successfully merged into the project! We greatly appreciate your efforts and the time you've dedicated to improving our repository. What happens next?
Once again, thank you for being part of our community! Best regards, |
JayDS22
added a commit
to JayDS22/apap
that referenced
this pull request
Jul 22, 2026
…ygiene wins (Jul 21) Updates the rolling roadmap for the Jul 21 milestone: the full service-layer chain (accordproject#211 templateService, accordproject#213 agreementService CRUD, accordproject#214 convertAgreement, accordproject#216 triggerAgreement) shipped upstream, plus the CI hygiene set (accordproject#210 crypto stub, accordproject#212 test-swallow, accordproject#215 server install) landed Jul 20-21. - Status header: bump to W8 day 1 / Jul 21, restate the merge count from eight to fifteen, headline the service-layer completion. - Workstream 1 (Proposal Core): reframe as "service-layer port complete upstream" with slice 3 REST unification as the remaining piece. - W7 row: flip Active -> Done, add the seven Jul 20-21 merges to the activity list. - Contributions table: add rows for accordproject#210, accordproject#211, accordproject#212, accordproject#213, accordproject#214, accordproject#215, accordproject#216, plus issue accordproject#217 (MCP paged reads follow-up), plus a combined row for the peer-review APPROVEs on Satvik's accordproject#192 + accordproject#203. Signed-off-by: Jay Guwalani <guwalanijj@gmail.com>
This was referenced Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
server/package.jsonlistedcrypto@1.0.1as a runtime dependency. That is not the Node builtincrypto; it is a registry stub that npm itself marks asdeprecated: "This package is no longer supported. It's now a built-in Node module. If you've depended on crypto, you should switch to the one that's built-in.".What this PR does
crypto: 1.0.1line fromserver/package.jsonserver/package-lock.json(only thenode_modules/cryptoentry drops, no other deps bump)Why the stub is a no-op
Bare specifiers like
import * as crypto from 'crypto'resolve to Node's builtin regardless of what is undernode_modules/. Node builtins take precedence over installed packages, so the stub was doing nothing at runtime except wasting install-time bandwidth and confusing anyone reading the manifest.Validation
import * as crypto from 'crypto'call site isserver/handlers/mcp.ts:7, still resolves to the Node builtin after removalnpm testinserver/: 8/8 test suites pass (98 tests including the recently landedhandlers/mcp-session-cleanup.test.ts,handlers/crud.test.ts, andhandlers/mcp.test.ts)cryptostub entry only.crypto-js(a legitimate different package) is untouched.Author Checklist