Skip to content

fix(markdown-common): retain empty nodes arrays in AST to satisfy strict=true in concerto-v4 #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mttrbrts merged 1 commit into from
Apr 10, 2026
Merged

fix(markdown-common): retain empty nodes arrays in AST to satisfy strict=true in concerto-v4 #652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/markdown-cicero/lib/__snapshots__/CommonMarkSpec.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,14 +484,17 @@ exports[`markdown-spec converts ATX headings-49 to concerto 1`] = `
{
"$class": "org.accordproject.commonmark@0.5.0.Heading",
"level": "2",
"nodes": [],
},
{
"$class": "org.accordproject.commonmark@0.5.0.Heading",
"level": "1",
"nodes": [],
},
{
"$class": "org.accordproject.commonmark@0.5.0.Heading",
"level": "3",
"nodes": [],
},
],
"xmlns": "http://commonmark.org/xml/1.0",
Expand Down Expand Up @@ -1656,6 +1659,7 @@ exports[`markdown-spec converts Block quotes-209 to concerto 1`] = `
"nodes": [
{
"$class": "org.accordproject.commonmark@0.5.0.BlockQuote",
"nodes": [],
},
],
"xmlns": "http://commonmark.org/xml/1.0",
Expand All @@ -1668,6 +1672,7 @@ exports[`markdown-spec converts Block quotes-210 to concerto 1`] = `
"nodes": [
{
"$class": "org.accordproject.commonmark@0.5.0.BlockQuote",
"nodes": [],
},
],
"xmlns": "http://commonmark.org/xml/1.0",
Expand Down Expand Up @@ -10394,6 +10399,7 @@ exports[`markdown-spec converts Link reference definitions-187 to concerto 1`] =
},
{
"$class": "org.accordproject.commonmark@0.5.0.BlockQuote",
"nodes": [],
},
],
"xmlns": "http://commonmark.org/xml/1.0",
Expand Down Expand Up @@ -13982,6 +13988,7 @@ exports[`markdown-spec converts List items-250 to concerto 1`] = `
"nodes": [
{
"$class": "org.accordproject.commonmark@0.5.0.Item",
"nodes": [],
},
],
"tight": "true",
Expand Down Expand Up @@ -14024,6 +14031,7 @@ exports[`markdown-spec converts List items-251 to concerto 1`] = `
},
{
"$class": "org.accordproject.commonmark@0.5.0.Item",
"nodes": [],
},
{
"$class": "org.accordproject.commonmark@0.5.0.Item",
Expand Down Expand Up @@ -14071,6 +14079,7 @@ exports[`markdown-spec converts List items-252 to concerto 1`] = `
},
{
"$class": "org.accordproject.commonmark@0.5.0.Item",
"nodes": [],
},
{
"$class": "org.accordproject.commonmark@0.5.0.Item",
Expand Down Expand Up @@ -14119,6 +14128,7 @@ exports[`markdown-spec converts List items-253 to concerto 1`] = `
},
{
"$class": "org.accordproject.commonmark@0.5.0.Item",
"nodes": [],
},
{
"$class": "org.accordproject.commonmark@0.5.0.Item",
Expand Down Expand Up @@ -14153,6 +14163,7 @@ exports[`markdown-spec converts List items-254 to concerto 1`] = `
"nodes": [
{
"$class": "org.accordproject.commonmark@0.5.0.Item",
"nodes": [],
},
],
"tight": "true",
Expand Down Expand Up @@ -15940,6 +15951,7 @@ exports[`markdown-spec converts Lists-285 to concerto 1`] = `
},
{
"$class": "org.accordproject.commonmark@0.5.0.Item",
"nodes": [],
},
{
"$class": "org.accordproject.commonmark@0.5.0.Item",
Expand Down
5 changes: 0 additions & 5 deletions packages/markdown-common/lib/FromMarkdownIt.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,11 +173,6 @@ class FromMarkdownIt {
} else if (rule.close) {
const node = stack.pop();
if (rule.exit) { rule.exit(node,token,FromMarkdownIt.inlineCallback(rules)); }
if (token.type !== 'paragraph_close') {
if (node.nodes.length === 0) {
delete node.nodes;
}
}
}
}

Expand Down
12 changes: 12 additions & 0 deletions packages/markdown-common/lib/__snapshots__/CommonMarkSpec.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,14 +484,17 @@ exports[`markdown-spec converts ATX headings-49 to concerto JSON 1`] = `
{
"$class": "org.accordproject.commonmark@0.5.0.Heading",
"level": "2",
"nodes": [],
},
{
"$class": "org.accordproject.commonmark@0.5.0.Heading",
"level": "1",
"nodes": [],
},
{
"$class": "org.accordproject.commonmark@0.5.0.Heading",
"level": "3",
"nodes": [],
},
],
"xmlns": "http://commonmark.org/xml/1.0",
Expand Down Expand Up @@ -1656,6 +1659,7 @@ exports[`markdown-spec converts Block quotes-209 to concerto JSON 1`] = `
"nodes": [
{
"$class": "org.accordproject.commonmark@0.5.0.BlockQuote",
"nodes": [],
},
],
"xmlns": "http://commonmark.org/xml/1.0",
Expand All @@ -1668,6 +1672,7 @@ exports[`markdown-spec converts Block quotes-210 to concerto JSON 1`] = `
"nodes": [
{
"$class": "org.accordproject.commonmark@0.5.0.BlockQuote",
"nodes": [],
},
],
"xmlns": "http://commonmark.org/xml/1.0",
Expand Down Expand Up @@ -10394,6 +10399,7 @@ exports[`markdown-spec converts Link reference definitions-187 to concerto JSON
},
{
"$class": "org.accordproject.commonmark@0.5.0.BlockQuote",
"nodes": [],
},
],
"xmlns": "http://commonmark.org/xml/1.0",
Expand Down Expand Up @@ -13982,6 +13988,7 @@ exports[`markdown-spec converts List items-250 to concerto JSON 1`] = `
"nodes": [
{
"$class": "org.accordproject.commonmark@0.5.0.Item",
"nodes": [],
},
],
"tight": "true",
Expand Down Expand Up @@ -14024,6 +14031,7 @@ exports[`markdown-spec converts List items-251 to concerto JSON 1`] = `
},
{
"$class": "org.accordproject.commonmark@0.5.0.Item",
"nodes": [],
},
{
"$class": "org.accordproject.commonmark@0.5.0.Item",
Expand Down Expand Up @@ -14071,6 +14079,7 @@ exports[`markdown-spec converts List items-252 to concerto JSON 1`] = `
},
{
"$class": "org.accordproject.commonmark@0.5.0.Item",
"nodes": [],
},
{
"$class": "org.accordproject.commonmark@0.5.0.Item",
Expand Down Expand Up @@ -14119,6 +14128,7 @@ exports[`markdown-spec converts List items-253 to concerto JSON 1`] = `
},
{
"$class": "org.accordproject.commonmark@0.5.0.Item",
"nodes": [],
},
{
"$class": "org.accordproject.commonmark@0.5.0.Item",
Expand Down Expand Up @@ -14153,6 +14163,7 @@ exports[`markdown-spec converts List items-254 to concerto JSON 1`] = `
"nodes": [
{
"$class": "org.accordproject.commonmark@0.5.0.Item",
"nodes": [],
},
],
"tight": "true",
Expand Down Expand Up @@ -15940,6 +15951,7 @@ exports[`markdown-spec converts Lists-285 to concerto JSON 1`] = `
},
{
"$class": "org.accordproject.commonmark@0.5.0.Item",
"nodes": [],
},
{
"$class": "org.accordproject.commonmark@0.5.0.Item",
Expand Down
4 changes: 4 additions & 0 deletions packages/markdown-common/lib/__snapshots__/CommonMarkTransformer.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1283,10 +1283,12 @@ exports[`markdown converts heading-empty.md to concerto JSON 1`] = `
{
"$class": "org.accordproject.commonmark@0.5.0.Heading",
"level": "1",
"nodes": [],
},
{
"$class": "org.accordproject.commonmark@0.5.0.Heading",
"level": "2",
"nodes": [],
},
{
"$class": "org.accordproject.commonmark@0.5.0.Heading",
Expand Down Expand Up @@ -1956,6 +1958,7 @@ exports[`markdown converts miniblockquote2.md to concerto JSON 1`] = `
"nodes": [
{
"$class": "org.accordproject.commonmark@0.5.0.Item",
"nodes": [],
},
],
"tight": "true",
Expand All @@ -1971,6 +1974,7 @@ exports[`markdown converts miniblockquote2.md to concerto JSON 1`] = `
"nodes": [
{
"$class": "org.accordproject.commonmark@0.5.0.Item",
"nodes": [],
},
],
"tight": "true",
Expand Down
Loading