Skip to content

fix(*): remove generated test declaration files from types follow-up#665

Merged
mttrbrts merged 6 commits into
accordproject:mainfrom
Rishabh060105:Rishabh060105/pr649-followup-remove-test-dts
May 9, 2026
Merged

fix(*): remove generated test declaration files from types follow-up#665
mttrbrts merged 6 commits into
accordproject:mainfrom
Rishabh060105:Rishabh060105/pr649-followup-remove-test-dts

Conversation

@Rishabh060105
Copy link
Copy Markdown
Contributor

Follow-up to #649

This PR follows up on #649 by removing stale generated *.test.d.ts artifacts that are still present in the published types/ tree.

Changes

  • Removed generated test declaration files from packages/markdown-common/types/lib
  • Removed generated test declaration files from packages/markdown-cicero/types/lib
  • Removed generated test declaration files from packages/markdown-html/types/lib

Flags

Screenshots or Video

  • Not applicable

Related Issues

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from Rishabh060105/pr649-followup-remove-test-dts

salama968 and others added 6 commits April 29, 2026 07:36
Signed-off-by: ahmedsalama <slamah968@gmail.com>
Signed-off-by: ahmedsalama <slamah968@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: ahmedsalama <slamah968@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: ahmedsalama <slamah968@gmail.com>
Signed-off-by: ahmedsalama <slamah968@gmail.com>
…#649 follow-up

Signed-off-by: Rishabh Jain <rishabhj2005@gmail.com>
@Rishabh060105
Copy link
Copy Markdown
Contributor Author

Rishabh060105 commented May 9, 2026

Hi @mttrbrts, I opened a small follow-up for #649 to address the remaining generated test typings that were still present in the published types/ output.

This follow-up only removes the stale declaration artifacts, specifically the *.test.d.ts files under:

  • packages/markdown-common/types/lib
  • packages/markdown-cicero/types/lib
  • packages/markdown-html/types/lib

I kept it intentionally narrow so it doesn’t change @salama968 broader TypeScript declaration approach, and only cleans up files that would otherwise be shipped from the types/ folder.

@mttrbrts mttrbrts merged commit 5813e78 into accordproject:main May 9, 2026
9 checks passed
@mttrbrts
Copy link
Copy Markdown
Member

mttrbrts commented May 9, 2026

@salama968 @Rishabh060105 Thank you both. This PR contains both of your commits and you'll both be marked as contributors. Great collaboration!

@mttrbrts
Copy link
Copy Markdown
Member

mttrbrts commented May 9, 2026

Thanks for the clean-up @Rishabh060105. The stale test declaration files are now removed and this has been merged.

As a follow-up, I've opened #668 to track improving the type quality — replacing the any return types with actual Concerto DOM types on the key public transformer APIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants