Remove PyBIDS get_associations() for JSON sidecars - #1450
Merged
cmadjar merged 1 commit intoJul 8, 2026
Conversation
github-actions
Bot
added
Language: Python
MaximeBICMTL
added
Category: Bug
cmadjar
approved these changes
Jul 7, 2026
Collaborator
|
@MaximeBICMTL this one too will need a rebase on 29.0-release to fix the tests |
MaximeBICMTL
force-pushed
the
remove-pybids-associations
branch
from
July 8, 2026 03:43
c4bbb71 to
653656f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyBIDS'
get_associations()is bugged, see bids-standard/pybids#1253, avoid this function to get JSON sidecars.I did not change the code for
eventsandphysiofiles as I am not sure of the exact expected behavior.Note that as a general principle, I don't think we should use PyBIDS for our BIDS utils, our needs are just too different.