Skip to content

[FilesUploadHandler] Add preliminary check for path traversal #10382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
driusan merged 1 commit into from
Apr 1, 2026
Merged

[FilesUploadHandler] Add preliminary check for path traversal #10382

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion php/libraries/FilesUploadHandler.class.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,11 +157,21 @@ class FilesUploadHandler implements RequestHandlerInterface
);
}

$filename = $file->getClientFilename();

if (str_contains($filename, "/") === true
|| str_contains($filename, "..") === true
) {
return new \LORIS\Http\Response\JSON\Forbidden(
'Path traversal not allowed'
);
}

/* basename() is used here to prevent path traversal characters
* from being used.
*/
$targetPath = $this->uploadDirectory->getPathname() . '/' . basename(
$file->getClientFilename()
$filename
);

/* If file exists, set response code to 'Conflict' unless the
Expand Down
Loading