Copy both production and dev react to htdocs#10427
Merged
driusan merged 3 commits intoaces:27.0-releasefrom Mar 31, 2026
Merged
Copy both production and dev react to htdocs#10427driusan merged 3 commits intoaces:27.0-releasefrom
driusan merged 3 commits intoaces:27.0-releasefrom
Conversation
regisoc
approved these changes
Mar 30, 2026
Collaborator
regisoc
left a comment
There was a problem hiding this comment.
Test process:
- for each
make dev or npm run compile/make or npm run buildcase:- remove all files in
htdocs/vendor/js/reactfolder. - run the
make dev/make/npm run compile/npm run buildcommand. - check
htdocs/vendor/js/reactfolder is populated with:- react.development.js
- react-dom.development.js
- react.production.min.js
- react-dom.production.min.js.
- remove all files in
All 4 files copied successfully for all 4 cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The webpack config is incorrectly only copying one (production or dev) version of react to htdocs. This causes the login page to stop loading based on the sandbox flag, which may be trying to load one or the other.
The decision to copy or not in webpack is based on a NODE_ENV environment variable which is not used or documented anywhere in LORIS, and LORIS may dynamically choose one or the other based on the configuration variable which can be changed without recompiling.
Go back to copying both so that LORIS will load regardless of the sandbox flag.
This should fix #10425 (it was the only problem I had on a fresh install) but the issue is vague and claims there is another problem which I didn't experience.
Fixes #10400