Skip to content

Copy both production and dev react to htdocs#10427

Merged
driusan merged 3 commits intoaces:27.0-releasefrom
driusan:FixSandboxFlag
Mar 31, 2026
Merged

Copy both production and dev react to htdocs#10427
driusan merged 3 commits intoaces:27.0-releasefrom
driusan:FixSandboxFlag

Conversation

@driusan
Copy link
Copy Markdown
Collaborator

@driusan driusan commented Mar 26, 2026

The webpack config is incorrectly only copying one (production or dev) version of react to htdocs. This causes the login page to stop loading based on the sandbox flag, which may be trying to load one or the other.

The decision to copy or not in webpack is based on a NODE_ENV environment variable which is not used or documented anywhere in LORIS, and LORIS may dynamically choose one or the other based on the configuration variable which can be changed without recompiling.

Go back to copying both so that LORIS will load regardless of the sandbox flag.

This should fix #10425 (it was the only problem I had on a fresh install) but the issue is vague and claims there is another problem which I didn't experience.

Fixes #10400

@github-actions github-actions bot added the Language: Javascript PR or issue that update Javascript code label Mar 26, 2026
@driusan driusan added Critical to release PR or issue is key for the release to which it has been assigned Difficulty: Medium PR or issue that require a moderate effort or expertise to implement, review, or test and removed Language: Javascript PR or issue that update Javascript code labels Mar 26, 2026
@driusan driusan changed the base branch from main to 27.0-release March 26, 2026 17:10
@github-actions github-actions bot added the Language: Javascript PR or issue that update Javascript code label Mar 26, 2026
@github-actions github-actions bot added Language: PHP PR or issue that update PHP code Module: electrophysiology_browser PR or issue related to electrophysiology_browser module Module: media PR or issue related to media module labels Mar 27, 2026
Copy link
Copy Markdown
Collaborator

@regisoc regisoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test process:

  • for each make dev or npm run compile/make or npm run build case:
    • remove all files in htdocs/vendor/js/react folder.
    • run the make dev/make/npm run compile/npm run build command.
    • check htdocs/vendor/js/react folder is populated with:
      • react.development.js
      • react-dom.development.js
      • react.production.min.js
      • react-dom.production.min.js.

All 4 files copied successfully for all 4 cases.

@driusan driusan merged commit 8c7c887 into aces:27.0-release Mar 31, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Critical to release PR or issue is key for the release to which it has been assigned Difficulty: Medium PR or issue that require a moderate effort or expertise to implement, review, or test Language: Javascript PR or issue that update Javascript code Language: PHP PR or issue that update PHP code Module: electrophysiology_browser PR or issue related to electrophysiology_browser module Module: media PR or issue related to media module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Blank page on new install

2 participants