Install script installment #3 #299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ause $projectname wouldn't have been set yet
samirdas
added a commit
that referenced
this pull request
Mar 25, 2014
Install script installment #3
stellarxo
pushed a commit
to stellarxo/Loris
that referenced
this pull request
May 9, 2016
cleaning code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handling data path and imagepath
Creating ../project/libraries, ../project/templates, and ../project/instruments by default
Adding some consistency and fixing a bug where the sed would actually fail because $projectname wouldn't have been set yet
Renaming PROJECT to PROJECTNAME for docs config.xml placeholder
Changing items asked in list of questions from alphabets to numbers
Install script now logging, tested rather thoroughly, though STDIN not yet being recorded in log file
Default config file now includes DownloadPath element and install script handles it appropriately
Improved overall robustness and cosmetic display for the user
Reshuffling around more stuff, making more sense/technically precise
Fixed bug where extra '/' was at the end of $projectname in sed statement
User input is now being logged