[Imaging Uploader] Fix "Please click here to go back" link RM13189 #3163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidblader
commented
Sep 28, 2017
| $upload_max_size = ini_get('upload_max_filesize'); | ||
| $error_message = "Please make sure files are not larger than " . | ||
| $upload_max_size . "<br>Please refresh this page to return ". | ||
| $upload_max_size . "Please refresh this page to return ". |
Contributor
Author
There was a problem hiding this comment.
html is now escaped so get rid of unsightly <br> tags
davidblader
commented
Sep 28, 2017
| </p> | ||
| <p> | ||
| <a href="javascript:history.back(-1)"> | ||
| <a href="javascript:history.back()"> |
Contributor
Author
There was a problem hiding this comment.
history.back() doesn't take any arguments
kongtiaowang
added
the
Passed manual tests
ridz1208
approved these changes
Oct 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://redmine.cbrain.mcgill.ca/issues/13189
history.back() does not work here, possibly because ?? React? Rendering the LorisException using document.write() ? i'm not really sure.
i don't like this fix very much, hopefully somebody has a better idea?