[Scripts] Fix_canadidate_age.php - PHP Fatal error#3371
Merged
driusan merged 1 commit intoaces:19.0-devfrom Jan 4, 2018
Merged
[Scripts] Fix_canadidate_age.php - PHP Fatal error#3371driusan merged 1 commit intoaces:19.0-devfrom
driusan merged 1 commit intoaces:19.0-devfrom
Conversation
zaliqarosli
changed the title
ridz1208
reviewed
Jan 3, 2018
| * | ||
| * @param Module $module The test name being accessed | ||
| * @param string $page The subtest being accessed (may be null) | ||
| * @param string $page The subtest being accessed (may be an empty string) |
Collaborator
There was a problem hiding this comment.
@zaliqarosli why was this modified ?
EDIT: sorry I havent had my coffee yet
ridz1208
approved these changes
Jan 3, 2018
driusan
approved these changes
Jan 3, 2018
Collaborator
driusan
left a comment
driusan
left a comment
There was a problem hiding this comment.
looks good, will merge after it passes Travis.
Collaborator
|
@kongtiaowang could you test it please ? |
zaliqarosli
added
Category: Bug
kongtiaowang
added
the
Passed manual tests
driusan
removed
the
Critical to release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes Redmine Bug #13701 by getting rid of the null argument. Comments regarding the null have also been modified.
See also: https://redmine.cbrain.mcgill.ca/issues/13701