[Version] Version #3445
Merged
[Version] Version #3445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ridz1208
added
the
Critical to release
Collaborator
|
why was this closed? |
Collaborator
Author
|
see linked PR |
Contributor
what linked PR? the one I refer to is on the MRI side as I was tagging @christinerogers and @cmadjar for an MRI discussion! |
Collaborator
Author
|
ooops |
Collaborator
Author
Collaborator
|
@ridz1208 I didn't merge it because it's an RC, not the final release. |
christinerogers
previously approved these changes
Feb 12, 2018
Contributor
christinerogers
left a comment
christinerogers
left a comment
There was a problem hiding this comment.
I approve this pull request.
ridz1208
force-pushed
the
2018_01_24_version
branch
from
239b4de to
2db9087
Compare
Collaborator
|
This is really stupid, but.. can you rebase this so it passes Travis? |
kongtiaowang
added
the
Passed manual tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes version number