Skip to content

Conversation

@kongtiaowang
Copy link
Contributor

@kongtiaowang kongtiaowang commented Jan 29, 2018

This pull request fixes bug in dashboard "incomplete tests" section.
https://redmine.cbrain.mcgill.ca/issues/13820

@kongtiaowang kongtiaowang added this to the 19.0 milestone Jan 29, 2018
@kongtiaowang kongtiaowang added [branch] bugfix Category: Bug PR or issue that aims to report or fix a bug and removed [branch] bugfix labels Jan 29, 2018
@kongtiaowang kongtiaowang requested a review from ridz1208 January 29, 2018 19:16
@ridz1208
Copy link
Collaborator

@kongtiaowang failing travis

@kongtiaowang
Copy link
Contributor Author

@ridz1208
it has passed the travis

@ridz1208 ridz1208 added the Passed manual tests PR has been successfully tested by at least one peer label Jan 31, 2018
Copy link
Collaborator

@driusan driusan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double checked with the query in the code, seems to still have site restrictions, and I don't know any more about this link than that, so it looks good..

@driusan driusan merged commit 964bf9a into aces:19.0-dev Jan 31, 2018
@ridz1208
Copy link
Collaborator

@kongtiaowang I'm having the same issue again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Category: Bug PR or issue that aims to report or fix a bug Passed manual tests PR has been successfully tested by at least one peer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants