Added On Duplicate Update Function to Database Class

[HenriRabalais]

This pull request adds two new methods to the database class: insertOnDuplicateUpdate() and unsafeInsertOnDuplicateUpdate()

These methods will attempt to insert a new row into the database given the query array passed as an argument. However, if one of the values to be inserted is a duplicate value for a unique key column, the query will be changed to an update statement for the row where the duplicate was found.

The unsafe version of the method will not escape insertion of HTML characters or JSON objects.

Reference:
https://dev.mysql.com/doc/refman/8.0/en/insert-on-duplicate.html

This PR also includes a use-case in the media module, which consolidates a few lines of code using the new function.

How to test:

1. Go to Media module and click on the Upload tab.
2. Upload a file according the naming convention stated at the top of the form.
3. Confirm that the file was uploaded by finding the entry in the Media module filter.
4. Click the edit button, edit a field (e.g. data) and click Update.
5. Ensure that the file was properly edited by checking the entry in the Media module filter.

[um4r12]

small typo: determines whether the insert throws and error -> determines whether the insert throws an error.

[nicolasbrossard]

Let's say a call to your new method is made in these situations:

1. Record does not exist and is inserted.
2. Record exists and is updated.
3. Record exists but is not updated.

What will be returned by getLastInsertID() for each case? Might be worth adding this to the documentation somewhere.

[HenriRabalais]

@nicolasbrossard

Since getLastInsertID() only returns the value of the last insert to the database, the following would occur:

1. Returns ID of newly inserted row.
2. Does not return ID of updated row.
3. Does not return ID of updated row.

Perhaps it would be useful to have the insertOnDuplicateKeyUpdate() function return whether the a row was updated or inserted.
@driusan what are your thoughts?

[driusan]

void

[driusan]

Does MySQL or the PDO provide any way to determine if the row was inserted or updated? I'm not sure that it's worth the effort, because I'm not sure what practical use cases it would be needed in, but if it's trivial to add, go ahead.

Assuming that there's no way (short of a second select query) to determine that, I think documenting it in the function comment is sufficient.

[HenriRabalais]

Sounds good. Looks like there's ways to go about doing this, but it would required some combination of ROW_COUNT and LAST_INSERT_ID.

The MySQL documentation states:
With ON DUPLICATE KEY UPDATE, the affected-rows value per row is 1 if the row is inserted as a new row and 2 if an existing row is updated.

Resolved Typo

[colezweber]

After function rename commit, I was able to edit the date of administration and changes appeared in the module!

[miebeers]

Looks great! Was able to successfully upload a file, edit a field, and see the changes reflected in the database.

[victoriafoing]

Passed manual tests for me too.

[driusan]

Looks good, but can you send it to 20.0-release branch so that it can be used after the next release instead of needing to wait for 20.1? I think I saw a PR to 20.0 that I wanted to recommend using this for, but then realized it's not merged there..

[driusan]

Nevermind, I don't think it's appropriate where I thought in 20.0, so 20.1 is fine.

[zaliqarosli]

@driusan hey dave, is this PR ready to go?

[zaliqarosli]

from looking at line 382, should this line have a space after the comma in quotes? also, could we keep consistent with double and single quotes or is there a reason for the use of both here?

[HenriRabalais]

No, no space is necessary after the comma here. The _implodeAsPrepared function takes care of that, while _implodeWithKeys is a less specialized function that doesn't. And I left it as a double quotes because the line is identical to line 380, not for any specific functional purpose. If anything, in the context of this class, the single quotes on lines 379, 381 and 382 look out of place. Actually, the whole class is a bit of a mix tbh. But I really don't mind either way.

[driusan]

I thought this was already merged..