Fixed Statistics Permissions #3852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s All Profiles Permission
zaliqarosli
previously requested changes
Jul 26, 2018
| $accessAllProfiles = $user->hasPermission('access_all_profiles') && | ||
| $user->hasPermission('data_entry'); | ||
| return $user->hasCenterPermission('data_entry', $centerID) || | ||
| $accessAlProfiles; |
Contributor
There was a problem hiding this comment.
typo: $accessAllProfiles
HenriRabalais
added
the
Critical to release
HenriRabalais
added
Category: Bug
zaliqarosli
added
the
Passed manual tests
HenriRabalais
added
Testing
miebeers
approved these changes
Jul 26, 2018
Contributor
miebeers
left a comment
miebeers
left a comment
There was a problem hiding this comment.
Tested, and it works well for me too!
ridz1208
approved these changes
Jul 27, 2018
PapillonMcGill
approved these changes
Jul 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the Statistics Site Permissions to allow access to Users with Access All Profiles Permission.
How to test:
Refer to Dashboard TestPlan item 11 for further clarification:
https://github.com/aces/Loris/blob/20.0-release/modules/dashboard/test/TestPlan.md
Redmine Ticket:
https://redmine.cbrain.mcgill.ca/issues/14946