[Imaging Browser] Sequence type column#4692
Merged
driusan merged 1 commit intoaces:21.0-releasefrom May 31, 2019
Merged
Conversation
kongtiaowang
added
Category: Bug
Member
|
Passed manual testing.. |
maltheism
added
the
Passed manual tests
maltheism
approved these changes
May 27, 2019
Collaborator
|
@cmadjar can you review this? I don't think I know enough context about how the feature is supposed to work. |
cmadjar
approved these changes
May 30, 2019
Collaborator
cmadjar
left a comment
cmadjar
left a comment
There was a problem hiding this comment.
LGTM. Also tested it and it worked as expected. Thanks @kongtiaowang!
driusan
added a commit
to driusan/Loris
that referenced
this pull request
Jun 6, 2019
The imaging browser data table had a "Sequence Type" column added by aces#4692. This was unintentional, as the data is only there for the filter. The table does not properly format/display it and will likely not scale to large protocols. This sets the column back to hidden, but the filter should still work.
driusan
added a commit
that referenced
this pull request
Jun 6, 2019
The imaging browser data table had a "Sequence Type" column added by #4692. This was unintentional, as the data is only there for the filter. The table does not properly format/display it and will likely not scale to large protocols. This sets the column back to hidden, but the filter should still work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to resolve:
#4635