Skip to content

[configuration] Reactify module#8471

Open
driusan wants to merge 14 commits into
aces:mainfrom
driusan:ConfigurationReact
Open

[configuration] Reactify module#8471
driusan wants to merge 14 commits into
aces:mainfrom
driusan:ConfigurationReact

Conversation

@driusan
Copy link
Copy Markdown
Collaborator

@driusan driusan commented Mar 21, 2023

This rewritse the main page of the configuration module--which is the cause of the majority of our javascript warnings--with React. The configuration module was written with jQuery/smarty before we began using React.

The reactified version should work the same as the old with a few exceptions.

  1. Our standard React element types are used instead of custom ones. This means, unfortunately, that the tooltip description is gone because our standard elements do not support it.
  2. The tabs are fetched dynamically instead of all upfront.
  3. swals are used to notify the user about setting update success/failure.

Other than that, the module should be unchanged from the end-user perspective.

@kongtiaowang kongtiaowang added the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Dec 12, 2023
@driusan driusan removed the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Dec 12, 2023
@driusan
Copy link
Copy Markdown
Collaborator Author

driusan commented Dec 12, 2023

@kongtiaowang rebased

{

$this->safeGet($this->url . "/configuration/");
// wait for the React to render
Copy link
Copy Markdown
Contributor

@kongtiaowang kongtiaowang Dec 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace this function in this file. using safeFindElement replace findElements after Reactify.
private function _linkTest($text)
{
$this->safeClick(WebDriverBy::linkText($text));
$webActives = $this->safeFindElement(WebDriverBy::cssSelector(".active"));
$bodyText = $webActives->getText();
$this->assertStringContainsString($text, $bodyText);
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the testplan3 in the dashboard test, you can temporarily comment it out. I've identified a solution to address this issue, and I'll implement it later. https://github.com/kongtiaowang/Loris/pull/381/files#diff-2af5e853d357c98c23e22e3a7d855bc560485103cb82026fa408d7fdf6f3fa5d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

State: Needs work PR awaiting additional work by the author to proceed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants