[JSX] Revert CSV data transformation: replace flatMap with map #9784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HenriRabalais
added
the
26.0.0-bugs
Collaborator
|
@driusan Henri made the PR at my request to revert this change. Let's maybe assign it to someone who can thoroughl vet it on the dataquery in the next testing round |
kongtiaowang
added
the
Passed manual tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modifies the transformation of csvData in the DataTable component by replacing .flatMap() with .map().
• Before: csvData was a flattened array of mapped cells across all fields and rows.
• After: csvData is now a nested array (Array<Array>), preserving the structure of rows.
• This aligns better with expected downstream usage or fixes unintended flattening issues in CSV processing.