-
Notifications
You must be signed in to change notification settings - Fork 189
[login] allow for customization of the top left and righ logos #9787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This needs to go to 27.0-release, 26 is already out. |
|
@kongtiaowang any idea why it keeps telling me thast the tests are cancelled? |
|
@ridz1208 no idea.. I just restarted in case it was a temporary outage. |
|
@driusan @kongtiaowang still cant figure out the tests here |
raisinbread/RB_files/RB_Config.sql
Outdated
| INSERT INTO `Config` (`ID`, `ConfigID`, `Value`) VALUES (129,132,'false'); | ||
| INSERT INTO `Config` (`ID`, `ConfigID`, `Value`) VALUES (130,133,'EEGS3DataPath'); | ||
| INSERT INTO `Config` (`ID`, `ConfigID`, `Value`) VALUES (131,134,'false'); | ||
| INSERT INTO `Config` (`ID`, `ConfigID`, `Value`) VALUES (122,135,'/images/LORIS_logo_white.svg'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo : "122" to "132"
| 'logo_right_link' => $this->Config->getSetting('login_logo_right_link'), | ||
| 'baseurl' => $this->BaseURL, | ||
| 'currentyear' => date('Y'), | ||
| 'sandbox' => ($this->Config->getSetting("sandbox") === '1'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 'sandbox' => ($this->Config->getSetting("sandbox") === '1'), | |
| 'sandbox' => ($this->Config->getSetting("sandbox") === '1'), | |
| 'partner_logos' => $this->Config->getSetting('partner_logos'), |
Brief summary of changes
This PR should allow projects to define what logos they see in the top right and top left of the login page to replace the default LORIS and GITHUB logos.
Testing instructions (if applicable)
Link(s) to related issue(s)