Skip to content

Conversation

@ridz1208
Copy link
Collaborator

@ridz1208 ridz1208 commented May 9, 2025

Brief summary of changes

This PR should allow projects to define what logos they see in the top right and top left of the login page to replace the default LORIS and GITHUB logos.

Testing instructions (if applicable)

Link(s) to related issue(s)

  • Resolves # (Reference the issue this fixes, if any.)

@driusan
Copy link
Collaborator

driusan commented Jun 9, 2025

This needs to go to 27.0-release, 26 is already out.

@ridz1208 ridz1208 added the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Jun 9, 2025
@ridz1208 ridz1208 changed the base branch from 26.0-release to 27.0-release June 9, 2025 19:12
@github-actions github-actions bot added Language: SQL PR or issue that update SQL code RaisinBread PR or issue introducing/requiring improvements to the Raidinbread dataset Language: PHP PR or issue that update PHP code labels Jun 9, 2025
@CamilleBeau CamilleBeau self-assigned this Jun 9, 2025
@ridz1208 ridz1208 closed this Jun 10, 2025
@ridz1208 ridz1208 reopened this Jun 10, 2025
@ridz1208
Copy link
Collaborator Author

@kongtiaowang any idea why it keeps telling me thast the tests are cancelled?

@driusan
Copy link
Collaborator

driusan commented Jun 11, 2025

@ridz1208 no idea.. I just restarted in case it was a temporary outage.

@ridz1208
Copy link
Collaborator Author

@driusan @kongtiaowang still cant figure out the tests here

@driusan driusan changed the base branch from 27.0-release to main June 20, 2025 20:50
@kongtiaowang kongtiaowang reopened this Jul 3, 2025
INSERT INTO `Config` (`ID`, `ConfigID`, `Value`) VALUES (129,132,'false');
INSERT INTO `Config` (`ID`, `ConfigID`, `Value`) VALUES (130,133,'EEGS3DataPath');
INSERT INTO `Config` (`ID`, `ConfigID`, `Value`) VALUES (131,134,'false');
INSERT INTO `Config` (`ID`, `ConfigID`, `Value`) VALUES (122,135,'/images/LORIS_logo_white.svg');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo : "122" to "132"

'logo_right_link' => $this->Config->getSetting('login_logo_right_link'),
'baseurl' => $this->BaseURL,
'currentyear' => date('Y'),
'sandbox' => ($this->Config->getSetting("sandbox") === '1'),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'sandbox' => ($this->Config->getSetting("sandbox") === '1'),
'sandbox' => ($this->Config->getSetting("sandbox") === '1'),
'partner_logos' => $this->Config->getSetting('partner_logos'),

@marandmart marandmart closed this Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language: PHP PR or issue that update PHP code Language: SQL PR or issue that update SQL code RaisinBread PR or issue introducing/requiring improvements to the Raidinbread dataset State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants