Skip to content

Conversation

@driusan
Copy link
Collaborator

@driusan driusan commented May 16, 2025

"npm run lintfix;js" currently generates hundreds of changes because the rules enforced don't match the coding style of the codebase.

This fixes the rule for the number of lines between the tagblock and the params to match what's actually used by the codebase, and fixes the couple leftovers that were wrong.

@github-actions github-actions bot added Language: Javascript PR or issue that update Javascript code Module: issue_tracker PR or issue related to issue tracker module Module: dataquery PR or issue related to (new) dataquery module labels May 16, 2025
@driusan
Copy link
Collaborator Author

driusan commented May 16, 2025

@kongtiaowang can you review?

Copy link
Contributor

@kongtiaowang kongtiaowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@driusan driusan merged commit 2bfa4b6 into aces:main Jun 27, 2025
20 checks passed
SKADE2303 pushed a commit to SKADE2303/Loris that referenced this pull request Jul 10, 2025
"npm run lintfix;js" currently generates hundreds of changes because the
rules enforced don't match the coding style of the codebase.

This fixes the rule for the number of lines between the tagblock and the
params to match what's actually used by the codebase, and fixes the
couple leftovers that were wrong.
jeffersoncasimir pushed a commit to jeffersoncasimir/Loris that referenced this pull request Aug 11, 2025
"npm run lintfix;js" currently generates hundreds of changes because the
rules enforced don't match the coding style of the codebase.

This fixes the rule for the number of lines between the tagblock and the
params to match what's actually used by the codebase, and fixes the
couple leftovers that were wrong.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language: Javascript PR or issue that update Javascript code Module: dataquery PR or issue related to (new) dataquery module Module: issue_tracker PR or issue related to issue tracker module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants