-
Notifications
You must be signed in to change notification settings - Fork 189
[api/lib] instrument validation #9827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
regisoc
wants to merge
65
commits into
aces:26.0-release
Choose a base branch
from
regisoc:20250604_instrument_validate_update
base: 26.0-release
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[api/lib] instrument validation #9827
regisoc
wants to merge
65
commits into
aces:26.0-release
from
regisoc:20250604_instrument_validate_update
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@kongtiaowang can you make a quick review on this? |
Contributor
|
@regisoc LGTM |
Contributor
Author
|
@driusan assigning you for final review |
driusan
reviewed
Aug 26, 2025
Contributor
Author
|
@driusan re-asking for final review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
26.0.0-bugs
Issues that were raised during the release testing for 26.0.0
Area: API
PR or issue related to the API
Area: Instruments
PR or issue related instruments
Category: Bug
PR or issue that aims to report or fix a bug
Language: PHP
PR or issue that update PHP code
Module: api
PR or issue related to api module
Priority: High
PR or issue should be prioritised over others for review and testing
Project: HBCD
Issue or PR related to the HBCD project
RaisinBread
PR or issue introducing/requiring improvements to the Raidinbread dataset
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
This PR:
PUT/PATCH instrumentendpoints to actually validate the data payload received. The current process is calling theInstrument validate()method, but this method is NOT validating any data. It is only checking the instrumentdata_entry = completestatus, which is counter-intuitive.PATCH/PUT instrument flagendpoint. The flagdata_entry = 'complete'was checked before the db can be reached to perform the update, which is blocking the update. The current PR should not change the instrument front-end behaviour.Test instructions
data_entry = 'complete'flag/state.Data_entryfrom the front-end (directly in instrument, accessible by candidate_list > timepoint > instrument) with the right permissions. This should be doable with and without this fix./candidates/{candid}/{visit}/instruments/{instrument}/flags).403error withCan not update instruments that are flagged as complete.message returned.data_entry = 'in progress'flag, or update one with the previous1.endpoint./candidates/{candid}/{visit}/instruments/{instrument}).Link(s) to related issue(s)